Skip to content

Use supported Copilot model IDs in threat detection driver defaults#37233

Merged
pelikhan merged 2 commits into
copilot/add-dedicated-driver-detection-jobfrom
copilot/fix-model-names-detection-job
Jun 6, 2026
Merged

Use supported Copilot model IDs in threat detection driver defaults#37233
pelikhan merged 2 commits into
copilot/add-dedicated-driver-detection-jobfrom
copilot/fix-model-names-detection-job

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jun 6, 2026

The detection job was invoking unsupported model IDs in its two-phase driver, causing 400 The requested model is not supported and preventing detection output from being produced. This updates the default model names used by the detection path to supported Copilot IDs.

  • Problem scope

    • The failure was isolated to default model selection in actions/setup/js/detection_job_driver.cjs (triage + full analysis phases).
  • Changes

    • Updated Phase 1 default model from claude-haiku-4-5 to claude-haiku-4.5.
    • Updated Phase 2 default model from claude-sonnet-4-5 to claude-sonnet-4.5.
    • Kept environment override behavior unchanged (GH_AW_DETECTION_SMALL_MODEL, GH_AW_DETECTION_LARGE_MODEL).
    • Aligned inline documentation/comments with the new defaults.
  • Code example

    // before
    const DEFAULT_SMALL_MODEL = "claude-haiku-4-5";
    const DEFAULT_LARGE_MODEL = "claude-sonnet-4-5";
    
    // after
    const DEFAULT_SMALL_MODEL = "claude-haiku-4.5";
    const DEFAULT_LARGE_MODEL = "claude-sonnet-4.5";

Copilot AI and others added 2 commits June 5, 2026 23:46
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@pelikhan pelikhan marked this pull request as ready for review June 6, 2026 02:04
Copilot AI review requested due to automatic review settings June 6, 2026 02:04
@pelikhan pelikhan merged commit dcedf53 into copilot/add-dedicated-driver-detection-job Jun 6, 2026
1 check passed
@pelikhan pelikhan deleted the copilot/fix-model-names-detection-job branch June 6, 2026 02:04
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the threat-detection job’s two-phase driver defaults by switching Phase 1 (triage) and Phase 2 (full analysis) to supported Copilot model IDs, addressing the 400 The requested model is not supported failure when no environment overrides are provided.

Changes:

  • Updated Phase 1 default model from claude-haiku-4-5claude-haiku-4.5.
  • Updated Phase 2 default model from claude-sonnet-4-5claude-sonnet-4.5.
  • Simplified the BYOK provider missing-env error message to a single process.stderr.write(...) call (no behavior change).
Show a summary per file
File Description
actions/setup/js/detection_job_driver.cjs Updates default model IDs used by the detection driver’s triage + analysis phases and aligns inline docs/error string formatting.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants