Enforce tolowerequalfold by converting case-insensitive comparisons to strings.EqualFold

[Copilot]

tolowerequalfold was registered but not CI-enforced; remaining true-positive ToLower/ToUpper equality patterns blocked rollout. This PR replaces those comparisons with strings.EqualFold and enables analyzer enforcement in custom lint CI flags.

• Analyzer enforcement

  • Added -tolowerequalfold to custom linter flags in .github/workflows/cgo.yml.

• Case-insensitive comparison conversions

  • Replaced strings.ToLower(...) == ... / != ... with strings.EqualFold(...) across the listed parser/workflow/cli callsites (including multi-compare branches in workflow resolution and HTTPS scheme validation).
  • Removed now-redundant lowered temporary variables where comparisons moved to EqualFold.

• Guard behavior preserved

  • Left lowercase-detection self-compare idioms unchanged (strings.ToLower(x) == x / != x) in:
    • pkg/workflow/tools_validation_github.go
    • pkg/cli/logs_report_tools.go
    • pkg/cli/codemod_discussion_trigger_categories.go

• Additional repo-local violations resolved for enforcement

  • Converted current production violations also flagged by -tolowerequalfold in:
    • pkg/workflow/features.go
    • pkg/cli/codespace.go
    • pkg/cli/outcome_eval_review.go

// before
if strings.ToLower(parsed.Scheme) != "https" { ... }

// after
if !strings.EqualFold(parsed.Scheme, "https") { ... }

[Copilot]

Pull request overview

This PR enables enforcement of the tolowerequalfold custom analyzer in CI and updates remaining case-insensitive string equality patterns to use strings.EqualFold, removing now-redundant temporary lowercased variables where applicable.

Changes:

• Enabled -tolowerequalfold in the custom linter CI flags to make the analyzer enforceable.
• Replaced strings.ToLower/ToUpper(... ) ==/!= ... comparison patterns with strings.EqualFold(...) across workflow, parser, and CLI callsites.
• Simplified a few callsites by removing intermediate lower* variables that were only used for comparisons.

Show a summary per file

File	Description
pkg/workflow/strings.go	Switches a case-insensitive tool-name compare to strings.EqualFold.
pkg/workflow/resolve.go	Reworks workflow ID/display-name case-insensitive matching to use strings.EqualFold and removes redundant lowercased temporaries.
pkg/workflow/repo_memory_validation.go	Uses strings.EqualFold for reserved branch-prefix detection.
pkg/workflow/notify_comment.go	Uses strings.EqualFold to match frontmatter feature keys against the group-concurrency flag.
pkg/workflow/features.go	Uses strings.EqualFold for case-insensitive feature flag matching (frontmatter + environment).
pkg/parser/yaml_import.go	Uses strings.EqualFold for action definition filename detection (action.yml / action.yaml).
pkg/parser/schema_suggestions.go	Uses strings.EqualFold for exact schema field-name matching before fuzzy suggestions.
pkg/cli/outcome_eval_review.go	Uses strings.EqualFold for detecting "APPROVED" review state without uppercasing.
pkg/cli/import_url_fetcher.go	Uses strings.EqualFold for HTTPS scheme gating before attaching auth headers.
pkg/cli/forecast.go	Uses strings.EqualFold for case-insensitive remote workflow name matching.
pkg/cli/codespace.go	Uses strings.EqualFold for CODESPACES=true detection.
pkg/cli/add_workflow_resolution.go	Uses strings.EqualFold when scanning on: [ ... ] for workflow_dispatch.
.github/workflows/cgo.yml	Adds -tolowerequalfold to enforced custom linter flags.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 13/13 changed files
• Comments generated: 0