Prevent safe-outputs startup regressions in daily workflows#37272
Prevent safe-outputs startup regressions in daily workflows#37272Copilot wants to merge 5 commits into
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
Hey One thing that would help reviewers before marking this ready:
There's also one unchecked task remaining (security/quality validation), so this looks intentionally still in draft — just flagging the description gap for when it's ready to be promoted. If you'd like a hand, you can assign this prompt to your coding agent: Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "patchdiff.githubusercontent.com"See Network Configuration for more information.
|
There was a problem hiding this comment.
Pull request overview
This PR hardens safe-outputs startup by aligning the startup preflight validation with the safe-outputs HTTP server’s runtime module dependencies, preventing MODULE_NOT_FOUND regressions that can break multiple daily workflows that share the same safe-outputs bootstrap path.
Changes:
- Added
safe_outputs_mcp_arguments.cjsto the startup script’sREQUIRED_DEPSvalidation list. - Added a Vitest unit test asserting the startup script validates
safe_outputs_mcp_arguments.cjsbefore server startup.
Show a summary per file
| File | Description |
|---|---|
| actions/setup/sh/start_safe_outputs_server.sh | Expands preflight dependency validation to cover an additional server dependency. |
| actions/setup/js/start_safe_outputs_server.test.cjs | Adds a regression test to prevent dependency-check drift in the startup script. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 1
| REQUIRED_DEPS=( | ||
| "safe_outputs_mcp_server_http.cjs" | ||
| "safe_outputs_mcp_arguments.cjs" | ||
| "mcp_http_transport.cjs" | ||
| "mcp_logger.cjs" |
|
Refresh the branch and rerun checks, then summarize any remaining blockers.
|
Three daily workflows (Documentation Healer, Model Inventory Checker, Sentrux Report) kept failing after prior issue closure due to a shared runtime crash in safe-outputs startup (
MODULE_NOT_FOUNDforsafe_outputs_mcp_arguments.cjs). This PR addresses the common failure point instead of workflow-specific symptoms.Root-cause correction (shared startup path)
actions/setup/sh/start_safe_outputs_server.shto requiresafe_outputs_mcp_arguments.cjsinREQUIRED_DEPS.safe_outputs_mcp_server_http.cjs.Regression guard
actions/setup/js/start_safe_outputs_server.test.cjsto assert the startup script explicitly includessafe_outputs_mcp_arguments.cjsin dependency validation.Why this resolves all three failures