Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update token usage step summary to report AI credits #37374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update token usage step summary to report AI credits #37374
Changes from all commits
a087ecd217bc03File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[/tdd] Stale test name — the ET columns were removed, so this test no longer checks ET values in the markdown.
The current assertions only verify
**Total**exists and thattotalEffectiveTokens > 0on the summary object — neither of which is specific to the old ET-column behaviour. The name implies a table-content invariant that is no longer asserted.💡 Suggested rename
Rename to something that reflects what is actually being asserted:
Also remove or update the inline comment at line 1697 —
// The last entry's compounded ET equals totalEffectiveTokens so must appear in the table— since ET no longer appears in the table.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[/tdd]
appendStepSummarySectionis exported but not imported or directly unit-tested.buildStepSummarySectioncorrectly gets its own unit test (line ~546), but the companion functionappendStepSummarySectionis only exercised indirectly throughmain(). Since it has two distinct code paths — direct file write vs.core.summaryfallback — it's worth adding a focused test for each branch.💡 Suggested approach
Import the function:
Then add:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[/tdd] Both assertions match the same single
addRawcall, so neither guards against an accidental double-write regression.Since
appendStepSummarySectioncallsaddRawexactly once with the full section, adding atoHaveBeenCalledTimes(1)check would catch any future refactor that accidentally splits the section into multiple calls.💡 Suggested addition
The second assertion alone is sufficient to verify content; the
toHaveBeenCalledTimes(1)closes the gap.Uh oh!
There was an error while loading. Please reload this page.