[aw] Update legacy ET rate-limit guidance to AI Credits-first format#37400
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix daily team evolution insights workflow failure
[aw] Update legacy ET rate-limit guidance to AI Credits-first format
Jun 6, 2026
pelikhan
reviewed
Jun 6, 2026
|
|
||
| const etTableSection = buildETComputationTable(effectiveTokens, readTokenUsageMarkdown()); | ||
| const EFFECTIVE_TOKENS_PER_AI_CREDIT = 10000; | ||
| const legacyBudgetET = Number.parseInt(maxEffectiveTokens || "", 10); |
Copilot stopped work on behalf of
pelikhan due to an error
June 6, 2026 21:24
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the legacy effective-token (ET) rate-limit failure guidance so it matches the current AI Credits budgeting model and produces cleaner GitHub-issue-friendly output.
Changes:
- Switched the ET rate-limit guidance header to GitHub alert syntax (
> [!WARNING]) and simplified the template contract to only{budget_line}. - Updated
buildEffectiveTokensRateLimitErrorContextto generate AI Credits-first remediation, including a computed “Suggestedmax-ai-credits” derived from legacymax-effective-tokenswhen convertible. - Refreshed focused tests to assert the new alert formatting, suggestion behavior, and removal of legacy ET/run/computation content.
Show a summary per file
| File | Description |
|---|---|
| actions/setup/md/effective_tokens_rate_limit_error.md | Converts the guidance header to GitHub alert syntax and removes legacy/duplicative ET-era placeholders/content. |
| actions/setup/js/handle_agent_failure.cjs | Simplifies ET rate-limit context generation to AI Credits-first output and updates template placeholder contract. |
| actions/setup/js/handle_agent_failure.test.cjs | Updates template fixture + assertions to match new alert formatting and AI Credits suggestion behavior. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 1
| throw new Error( | ||
| `failed to render template at ${templatePath}: ${getErrorMessage(error)}; ` + "verify template syntax and required placeholders: " + "ai_credits_spec_link, cost_management_link, usage_line, budget_line, run_line, et_table_section" | ||
| ); | ||
| throw new Error(`failed to render template at ${templatePath}: ${getErrorMessage(error)}; ` + "verify template syntax and required placeholders: " + "{ai_credits_spec_link}, {cost_management_link}, {budget_line}"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Daily Team Evolution Insights failure reports still surfaced legacy effective-token details and nonstandard warning formatting, despite AI Credits being the active budgeting model. This update aligns the generated guidance with current
max-ai-creditspolicy and removes redundant/noisy ET-era output.Warning presentation (GitHub-native syntax)
[!WARNING]) in the ET rate-limit template.AI Credits-first remediation content
max-ai-credits.Suggested max-ai-creditsoutput derived from legacymax-effective-tokenswhen convertible.Removed legacy/duplicate details from generated issue body
Effective tokens used: ...Run: ...line (already present in issue metadata)Renderer and contract cleanup
buildEffectiveTokensRateLimitErrorContextinputs to only what is now used.