Rename file-close AST walker helper for clearer intent#37568
Merged
Conversation
9 tasks
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update function names in pkg/linters/fileclosenotdeferred
Rename file-close AST walker helper for clearer intent
Jun 7, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs a naming-only refactor in the fileclosenotdeferred analyzer to make an internal AST-walker helper’s intent more explicit, improving readability and discoverability without changing diagnostics or control flow.
Changes:
- Renamed the internal helper
inspectFileNodetoanalyzeASTNodeForFileClosePatterns. - Updated the single in-package call site used by
ast.Inspectto call the renamed helper.
Show a summary per file
| File | Description |
|---|---|
pkg/linters/fileclosenotdeferred/fileclosenotdeferred.go |
Renames the AST inspection callback helper and updates its call site to match. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update addresses the function-namer recommendation in
pkg/linters/fileclosenotdeferredby replacing an ambiguous internal helper name with one that explicitly describes its role in AST-based file-close pattern analysis. The goal is better readability and discoverability without changing analyzer behavior.Scope
inspectFileNodetoanalyzeASTNodeForFileClosePatternsinpkg/linters/fileclosenotdeferred/fileclosenotdeferred.go.inspectFileFuncDecl.Behavioral impact
Representative diff