Rename frontmatter_helpers.go to map_helpers.go

[Copilot]

Rename frontmatter_helpers.go to map_helpers.go

This PR renames pkg/workflow/frontmatter_helpers.go to pkg/workflow/map_helpers.go to better reflect its generic utility nature. The functions in this file (parseIntValue and filterMapKeys) are general-purpose map and parsing utilities, not frontmatter-specific logic.

Changes

• Understand the current codebase and verify tests pass
• Rename the file using git mv to preserve history
• Update documentation reference in frontmatter_extraction.go
• Create comprehensive test file (map_helpers_test.go) with 13 test cases
• Verify all tests still pass (make test-unit)
• Verify build succeeds (make build)
• Remove unrelated changes to super-linter.lock.yml
• Merge main branch

Test Coverage

Created pkg/workflow/map_helpers_test.go with comprehensive tests:

TestParseIntValue - 7 test cases covering:

• int, int64, uint64, float64 value parsing
• Unsupported types (string, nil, bool)

TestFilterMapKeys - 6 test cases covering:

• Single key filtering
• Multiple key filtering
• Empty exclusion list
• Non-existent key filtering
• Empty map handling
• Filter all keys scenario

Verification

✅ All unit tests pass (make test-unit)
✅ Build succeeds (make build)
✅ No references to old filename remain
✅ Git history preserved with git mv
✅ Unrelated changes removed from PR
✅ Main branch merged successfully

Related Issue

Addresses #3822 - Semantic function clustering analysis identified this misnamed file.

Original prompt

---

This section details on the original issue you should resolve

<issue_title>[task] Rename frontmatter_helpers.go to reflect generic utility nature</issue_title>
<issue_description>## Objective
Rename pkg/workflow/frontmatter_helpers.go to a more appropriate name that reflects its generic utility nature, since the functions it contains are not frontmatter-specific.

Context

The semantic function clustering analysis (issue #3822) identified that frontmatter_helpers.go contains generic map and parsing utilities that are not specific to frontmatter processing. The current name is misleading and makes the functions harder to discover.

This is a Priority 3 refactoring - low priority, long-term code quality improvement.

Current Functions in the File

• parseIntValue() - Generic integer parsing from map values
• filterMapKeys() - Generic map key filtering utility

These are general-purpose utilities, not frontmatter-specific logic.

Suggested New Names

Choose one of the following (in order of preference):

1. pkg/workflow/map_helpers.go (emphasizes map operations)
2. pkg/workflow/generic_helpers.go (emphasizes general utility nature)
3. pkg/workflow/parsing_helpers.go (emphasizes parsing utilities)

Files to Modify/Rename

• Rename: pkg/workflow/frontmatter_helpers.go → new name
• Update imports: Any files that import functions from this file (if import path changes)

Implementation Steps

1. Choose the most appropriate new name (recommend map_helpers.go)
2. Rename the file using git: git mv pkg/workflow/frontmatter_helpers.go pkg/workflow/map_helpers.go
3. Search for any imports of this file across the codebase
4. Update import statements if necessary (unlikely with internal package)
5. Update any documentation or comments that reference the old filename
6. Run tests to ensure no breakage: make test-unit
7. Run build to ensure no issues: make build

Acceptance Criteria

• File is renamed to reflect its generic nature
• All imports are updated if necessary
• All tests pass: make test-unit
• Build succeeds: make build
• No references to old filename remain in documentation
• Git history is preserved (used git mv)

Expected Benefits

• More accurate file naming
• Easier discoverability for developers
• Clearer code organization
• Better developer experience

Estimated Effort

30 minutes

Notes

• This is a low-priority refactoring
• Consider doing this after the higher priority refactorings
• The file only contains 2 functions, so impact is minimal
• Ensure git history is preserved by using git mv

Related

Related to #3822
Related to #3822

AI generated by Plan Command for #3822</issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes [task] Rename frontmatter_helpers.go to reflect generic utility nature #3834

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[Copilot]

Pull Request Overview

This PR renames frontmatter_helpers.go to map_helpers.go to better reflect that the file contains generic map utility functions rather than frontmatter-specific logic. The change improves code discoverability and organization.

Key changes:

• Renamed file using git mv to preserve history
• Added comprehensive test coverage with 13 test cases
• Updated documentation reference to reflect the new filename

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File	Description
pkg/workflow/map_helpers.go	Renamed from frontmatter_helpers.go, contains generic map utilities (parseIntValue, filterMapKeys)
pkg/workflow/map_helpers_test.go	New test file with comprehensive coverage for both utility functions
pkg/workflow/frontmatter_extraction.go	Updated comment to reference new filename map_helpers.go
.github/workflows/super-linter.lock.yml	Contains unrelated GitHub Actions version updates that should be in a separate PR

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

This file contains unrelated changes that should not be part of a PR focused on renaming frontmatter_helpers.go to map_helpers.go. The changes here update GitHub Actions versions:

• actions/download-artifact from a SHA to a different SHA (line 172)
• super-linter/super-linter from a SHA to tag v8.2.1 (line 4544)
• actions/upload-artifact from a SHA to a different SHA (line 4566)

These action version updates should be in a separate PR to keep changes focused and make code review easier.

[Copilot]

Reverted the unrelated changes to super-linter.lock.yml in commit da17689. The file now only contains changes from the main branch merge.

[pelikhan]

@copilot merge main

[Copilot]

@copilot merge main

Merged main branch successfully in commit da17689. All tests pass and build succeeds.