Remove hardcoded action pins lists from tests

[Copilot]

Tests contained hardcoded lists of action names that duplicated data already in action_pins.json, creating maintenance burden and incomplete coverage (14 of 18 actions tested).

Changes

Modified pkg/workflow/action_pins_test.go:

• TestActionPinsExist: Removed hardcoded 14-action array, now iterates over all actions from getActionPins()
• TestGetActionPinReturnsValidSHA: Removed hardcoded test table, dynamically generates test cases from getActionPins()

Before:

expectedActions := []string{
    "actions/checkout",
    "actions/github-script",
    // ... 12 more hardcoded entries
}
for _, action := range expectedActions {
    // test logic
}

After:

actionPins := getActionPins()  // Reads from action_pins.json
for _, pin := range actionPins {
    // test logic using pin.Repo
}

Impact

• Tests now cover all 18 actions in JSON (previously 14)
• Future JSON updates automatically reflected in tests
• Net -31 lines of code

Original prompt

Remove builtin action pins list and instead read the information from the actions_pins.json exclusively.

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[Copilot]

Pull Request Overview

This PR eliminates code duplication by removing hardcoded action lists from test files in favor of dynamically reading from the centralized action_pins.json file. The change improves maintainability by ensuring tests automatically cover all actions defined in the JSON configuration without requiring manual updates to test code.

Key changes:

• Replaced hardcoded 14-action test arrays with dynamic iteration over all actions from getActionPins()
• Tests now automatically cover all 18 actions in the JSON file (previously only 14)
• Added defensive checks to ensure action pins are successfully loaded before running tests

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.