Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the workflow polling mechanism to use a reusable signal-aware polling utility. The changes introduce PollWithSignalHandling, a generic function that handles timeouts and graceful Ctrl-C interruption for long-running operations.
Key changes:
- Created a new
signal_aware_poll.gomodule with a flexible polling utility - Refactored
WaitForWorkflowCompletionto use the new polling mechanism instead of custom polling logic - Added error handling for repository creation race conditions in trial command
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/cli/signal_aware_poll.go | New polling utility with signal handling, timeout support, and configurable callbacks |
| pkg/cli/signal_aware_poll_test.go | Comprehensive test coverage for the new polling utility including success, failure, timeout, and signal interruption cases |
| pkg/cli/pr_automerge.go | Refactored to use PollWithSignalHandling instead of custom polling loop |
| pkg/cli/pr_automerge_test.go | Added test to verify signal-aware polling integration |
| pkg/cli/trial_command.go | Added fallback error handling for "name already exists" race condition during repository creation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Key Changes
signal_aware_poll.gowith a flexiblePollWithSignalHandlingfunctionWaitForWorkflowCompletionusing the new polling mechanismImprovements