Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request optimizes the trial command by moving the workflow disabling logic earlier in the execution flow, from inside the runAllTrials function to before it. This ensures workflows are disabled only once rather than per trial iteration when using --repeat.
Key Changes
- Workflow disabling now occurs at Step 2.8, immediately after cloning repository contents (Step 2.7)
- A separate temporary directory clone (
tempDirForDisable) is created specifically for the workflow disabling operation - Error handling maintains the existing warning-level approach for non-critical failures
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RunWorkflowTrialsfunctionChanges