Standardize MCP command arguments to workflow-id-or-file#4014
Merged
Conversation
- Update all MCP command argument names from workflow-file to workflow-id-or-file - Add clarifying documentation about what workflow-id-or-file accepts - Update tests to match new terminology - Commands affected: mcp add, mcp inspect, mcp list, mcp list-tools - All commands already use ResolveWorkflowPath() helper which accepts both formats Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix inconsistent terminology for workflow arguments in CLI
Standardize MCP command arguments to workflow-id-or-file
Nov 15, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes the terminology used in MCP command arguments from workflow-file to workflow-id-or-file for consistency with other commands in the CLI (logs, enable, disable, run, update). The change improves documentation clarity by explicitly stating that both formats are accepted (workflow ID as basename without extension, or file path).
Key changes:
- Updated command signatures for all MCP subcommands to use
[workflow-id-or-file]instead of[workflow-file] - Added clarifying help text explaining the accepted input formats
- Updated test assertions to match new command signatures
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
pkg/cli/mcp_add.go |
Updated command signature to add [workflow-id-or-file] [mcp-server-name] and added help text explaining accepted formats; updated error messages |
pkg/cli/mcp_inspect.go |
Updated command signature to inspect [workflow-id-or-file] and added help text explaining accepted formats |
pkg/cli/mcp_list.go |
Updated command signature to list [workflow-id-or-file] and added help text explaining accepted formats; updated Long description references |
pkg/cli/mcp_list_tools.go |
Updated command signature to list-tools <mcp_server> [workflow-id-or-file] and added help text explaining accepted formats |
pkg/cli/mcp_list_test.go |
Updated test assertion to expect new command signature list [workflow-id-or-file] |
pkg/cli/mcp_list_tools_test.go |
Updated test assertion to expect new command signature list-tools <mcp_server> [workflow-id-or-file] |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Agentic Changeset Generator triggered by this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MCP commands used inconsistent
workflow-fileterminology while other commands (logs,enable,disable,run) usedworkflow-id. This created confusion about expected input format.Changes
Command signatures: Updated all MCP subcommands from
[workflow-file]to[workflow-id-or-file]mcp add [workflow-id-or-file] [mcp-server-name]mcp inspect [workflow-id-or-file]mcp list [workflow-id-or-file]mcp list-tools <mcp_server> [workflow-id-or-file]Help text: Added clarifying documentation to each command explaining accepted formats:
weekly-research)weekly-research.md,.github/workflows/weekly-research.md)Tests: Updated test assertions to match new command signatures
Implementation
All commands already use
ResolveWorkflowPath()which accepts both formats. This change only updates documentation and command signatures for consistency.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.