[log] Add debug logging to 5 additional Go files#4037
Merged
Conversation
Enhanced the following files with debug logging statements: 1. **pkg/cli/update_command.go** - Added logging for workflow update lifecycle - Update process initiation with parameters - Workflow scanning and discovery - Ref resolution and version detection - Merge operations and conflict detection - Compilation status 2. **pkg/parser/mcp.go** - Added logging for MCP configuration parsing - MCP configuration extraction with filters - Safe-outputs and safe-jobs detection - Built-in and custom MCP tool processing - MCP type inference (http, stdio, container) 3. **pkg/workflow/threat_detection.go** - Added logging for threat detection - Configuration parsing (enabled/disabled states) - AI engine configuration - Job building with step counts 4. **pkg/workflow/tools_types.go** - Added logging for tools configuration - Tools configuration creation with entry counts - GitHub tool configuration parsing - Custom tools detection 5. **pkg/parser/github_urls.go** - Added logging for GitHub URL parsing - URL parsing and validation - Host and type detection - File, PR, issue, and run URL handling All logging follows project guidelines: - No side effects in logger arguments - Meaningful messages for debugging - Proper logger naming conventions - Function entry logging with parameters 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhanced the following files with debug logging statements to help with troubleshooting and development:
Files Enhanced
1. pkg/cli/update_command.go - Workflow Update Lifecycle Logging
2. pkg/parser/mcp.go - MCP Configuration Parsing
3. pkg/workflow/threat_detection.go - Threat Detection Configuration
4. pkg/workflow/tools_types.go - Tools Configuration
5. pkg/parser/github_urls.go - GitHub URL Parsing
Quality Checklist
make build(no compilation errors)DEBUG=* ./gh-aw compile devLogging Guidelines Followed
All enhancements follow the project's logging guidelines from AGENTS.md:
Example Debug Output
When running with
DEBUG=*, you can now see detailed logging like:🤖 Generated with Claude Code
Co-Authored-By: Claude (noreply@anthropic.com)