Skip to content

Allow explicit "latest" version for Playwright while defaulting to pinned version#4101

Merged
pelikhan merged 2 commits intoq-pin-playwright-version-08c145387afb3b72from
copilot/sub-pr-4100
Nov 15, 2025
Merged

Allow explicit "latest" version for Playwright while defaulting to pinned version#4101
pelikhan merged 2 commits intoq-pin-playwright-version-08c145387afb3b72from
copilot/sub-pr-4100

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Nov 15, 2025

Feedback requested allowing users to explicitly choose version: "latest" for Playwright. The code was blocking "latest" even when explicitly specified, forcing the pinned version in all cases.

Changes

  • Removed version blocking - Eliminated args.ImageVersion != "latest" condition that prevented explicit "latest" usage
  • Changed default behavior - Empty version now resolves to pinned version (1.56.1) instead of defaulting to "latest"
  • Updated TOML rendering - Codex engine now respects version configuration instead of hardcoding pinned version
  • Fixed test expectations - Tests now verify pinned version as default and explicit "latest" support

Behavior

# No version specified → uses pinned 1.56.1
tools:
  playwright:
    allowed_domains: ["example.com"]

# Explicit latest → uses latest
tools:
  playwright:
    version: "latest"
    allowed_domains: ["example.com"]

# Specific version → uses that version
tools:
  playwright:
    version: "1.55.0"
    allowed_domains: ["example.com"]

Compiled workflows now default to @playwright/mcp@1.56.1 instead of @playwright/mcp@latest, with users able to override to "latest" when desired.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Changes made:
- Remove condition that blocked "latest" from being used when explicitly set by user
- Change default from "latest" to empty string (pinned version used as fallback)
- Update TOML rendering to respect user-specified versions
- Update all tests to expect pinned version (1.56.1) as default
- Add new test to verify explicit "latest" is respected
- Update lock files to use pinned version for existing workflows

The user can now:
- Omit version → gets pinned version 1.56.1 (secure default)
- Set version: "latest" → gets latest (explicit choice respected)
- Set version: "1.55.0" → gets specific version (already worked)

This addresses the feedback to allow users to pick "latest" when they explicitly want it, while maintaining security by defaulting to a pinned version.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Update to address feedback on pinning Playwright version Allow explicit "latest" version for Playwright while defaulting to pinned version Nov 15, 2025
Copilot AI requested a review from pelikhan November 15, 2025 22:40
@pelikhan pelikhan marked this pull request as ready for review November 15, 2025 22:41
@pelikhan pelikhan merged commit ad8b678 into q-pin-playwright-version-08c145387afb3b72 Nov 15, 2025
84 of 91 checks passed
@pelikhan pelikhan deleted the copilot/sub-pr-4100 branch November 15, 2025 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants