eslint-factory: fix require-json-parse-try-catch to catch computed JSON["parse"] access

[Copilot]

The require-json-parse-try-catch rule silently missed JSON["parse"](x) — computed member access with a string literal key — because the property guard required an Identifier node, causing early return on Literal nodes.

Changes

• Rule fix (require-json-parse-try-catch.ts): Replace two separate property.type/property.name guards with a single isParseProperty predicate that accepts both Identifier (JSON.parse) and string Literal (JSON["parse"]) property nodes. Aliased and destructured bindings (const p = JSON.parse; p(x)) are documented as intentionally out of scope via inline comment.

• Tests (require-json-parse-try-catch.test.ts): Add JSON["parse"] inside try to the valid set; add new invalid test suite covering computed access both as assignment and bare expression statement.

// Before: only matched this
JSON.parse(raw);

// After: also matches this
JSON["parse"](raw);
// ↑ reports requireTryCatch with suggestion to wrap in try/catch

[Copilot]

Pull request overview

This PR fixes the require-json-parse-try-catch ESLint rule so it also flags computed string-literal JSON["parse"](...) calls (previously missed due to an overly strict property-node guard), and extends the rule’s tests to cover the new matching behavior.

Changes:

• Update rule logic to recognize both JSON.parse and JSON["parse"] member accesses.
• Add tests for computed-access valid/invalid cases and suggestion output.

Show a summary per file

File	Description
eslint-factory/src/rules/require-json-parse-try-catch.ts	Extends the rule’s callee-property matching to include computed string-literal access.
eslint-factory/src/rules/require-json-parse-try-catch.test.ts	Adds valid/invalid cases to ensure JSON["parse"](...) is handled and suggested fixes are correct.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comments suppressed due to low confidence (1)

eslint-factory/src/rules/require-json-parse-try-catch.test.ts:30

• The new computed-access support is only exercised in the CommonJS valid suite. Adding the same JSON["parse"] try/catch case to the ES module valid suite would help ensure the behavior is consistent across both sourceType modes.

  it("valid: JSON.parse inside try block passes (CommonJS)", () => {
    cjsRuleTester.run("require-json-parse-try-catch", requireJsonParseTryCatchRule, {
      valid: [`try { const x = JSON.parse(str); } catch (e) {}`, `try { return JSON.parse(str); } catch (e) {}`, `function f() { try { JSON.parse(str); } catch (e) {} }`, `try { const x = JSON["parse"](str); } catch (e) {}`],
      invalid: [],
    });
  });

  it("valid: JSON.parse inside try block passes (ES module)", () => {
    esmRuleTester.run("require-json-parse-try-catch", requireJsonParseTryCatchRule, {
      valid: [`try { const x = JSON.parse(str); } catch (e) {}`],
      invalid: [],

• Files reviewed: 2/2 changed files
• Comments generated: 2
• Review effort level: Low

[github-actions]

🎉 This pull request is included in a new release.

Release: v0.82.0