[q] Require explicit unresolved-review thread list in PR sous-chef nudges#42056
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add explicit list of unresolved PR reviews in nudge comment
[q] Require explicit unresolved-review thread list in PR sous-chef nudges
Jun 28, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens the PR Sous Chef “nudge” contract so that when unresolved PR review threads exist, the generated nudge comment must enumerate them directly (reviewer + deep link per thread, ordered newest-first), reducing rediscovery work for @copilot and maintainers.
Changes:
- Updated the PR sous-chef workflow contract to require an explicit unresolved-review thread list in the combined nudge comment.
- Updated the
pr-processorsub-agent output contract to include the unresolved-review list requirement when applicable. - Extended the workflow contract test to assert the presence of the new requirement and regenerated the compiled workflow artifact.
Show a summary per file
| File | Description |
|---|---|
| pkg/cli/pr_sous_chef_workflow_contract_test.go | Adds a contract assertion to ensure the workflow source text includes the unresolved-reviews-list requirement. |
| .github/workflows/pr-sous-chef.md | Tightens the nudge/sub-agent contract text to require explicit enumeration of unresolved review threads. |
| .github/workflows/pr-sous-chef.lock.yml | Regenerated compiled workflow artifact to reflect the updated markdown workflow body hash/content. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Low
Comment on lines
306
to
309
| 3. If not skipped, return: | ||
| - whether branch update should be attempted | ||
| - a single combined nudge comment body (covering unresolved review feedback, branch refresh, and any other forward-progress action) — one comment only, never two | ||
| - a single combined nudge comment body (covering unresolved review feedback, branch refresh, and any other forward-progress action) — one comment only, never two; if unresolved PR reviews exist, include an explicit unresolved-reviews list (reviewer + direct link per unresolved review thread) | ||
| 4. Make at most 8 tool calls total. If 8 calls are insufficient to reach a confident decision, set all fields to `null` and set `skip_reason: "insufficient_context"`. |
Comment on lines
28
to
30
| assert.Contains(t, text, "pr_number 12345", "Workflow should include a concrete add_comment pr_number example") | ||
| assert.Contains(t, text, "include an explicit unresolved-reviews list", "Workflow should require explicit unresolved review listing in nudge comments") | ||
| assert.Contains(t, text, "Process at most **5 PRs** per run.", "Workflow should cap per-run PR processing to 5") |
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR sous-chef nudges were asking @copilot to resolve review feedback, but did not require a concrete list of unresolved review items. This change tightens the nudge contract so unresolved PR reviews are enumerated directly in the comment, removing rediscovery work.
Workflow nudge contract
/home/runner/work/gh-aw/gh-aw/.github/workflows/pr-sous-chef.mdto require that when unresolved PR reviews exist, the nudge comment includes an explicit unresolved-reviews list with:Sub-agent output contract
pr-processorinstructions in the same workflow so its returned combined nudge body must include that explicit unresolved-reviews list when applicable.Contract guardrail test
/home/runner/work/gh-aw/gh-aw/pkg/cli/pr_sous_chef_workflow_contract_test.gowith an assertion that enforces presence of the unresolved-reviews-list requirement in workflow source text.Compiled workflow artifact
/home/runner/work/gh-aw/gh-aw/.github/workflows/pr-sous-chef.lock.ymlto reflect the updated markdown workflow body contract.- If unresolved PR reviews exist, include an explicit unresolved-reviews list in the nudge comment (reviewer + direct link for each unresolved review thread, newest first).