Skip to content

[aw] Agent Persona Explorer: fix cache-memory history path to prevent false cache_memory_miss#42112

Merged
pelikhan merged 2 commits into
mainfrom
copilot/aw-fix-cache-memory-miss
Jun 28, 2026
Merged

[aw] Agent Persona Explorer: fix cache-memory history path to prevent false cache_memory_miss#42112
pelikhan merged 2 commits into
mainfrom
copilot/aw-fix-cache-memory-miss

Conversation

Copilot AI commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Agent Persona Explorer was instructing the agent to read/write exploration history using a logical key, while cache-memory expects filesystem paths. This mismatch can produce missing_data with reason: cache_memory_miss even when cache restore succeeds.

  • Prompt contract correction

    • Updated history read/write instructions in agent-persona-explorer.md to use an explicit cache-memory file path:
      • /tmp/gh-aw/cache-memory/agent-persona-explorer/explored-personas.json
    • Clarified existence check semantics from “key does not exist” to “file does not exist”.
  • Compiled workflow sync

    • Recompiled agent-persona-explorer.lock.yml so runtime prompt content matches source markdown.
- 1. **Load history**: Read the key `agent-persona-explorer/explored-personas` from cache memory.
-    - If the key does not exist, treat the explored list as empty.
+ 1. **Load history**: Read `/tmp/gh-aw/cache-memory/agent-persona-explorer/explored-personas.json`.
+    - If the file does not exist, treat the explored list as empty.

- **Update the exploration history**: ... update `agent-persona-explorer/explored-personas` in cache memory:
+ **Update the exploration history**: ... update `/tmp/gh-aw/cache-memory/agent-persona-explorer/explored-personas.json`:

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix cache memory miss misconfiguration in Agent Persona Explorer [aw] Agent Persona Explorer: fix cache-memory history path to prevent false cache_memory_miss Jun 28, 2026
Copilot AI requested a review from pelikhan June 28, 2026 18:07
@pelikhan pelikhan marked this pull request as ready for review June 28, 2026 18:25
Copilot AI review requested due to automatic review settings June 28, 2026 18:25
@pelikhan pelikhan merged commit f503f30 into main Jun 28, 2026
@pelikhan pelikhan deleted the copilot/aw-fix-cache-memory-miss branch June 28, 2026 18:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects the Agent Persona Explorer prompt’s cache-memory contract by switching from a logical “key” reference to an explicit filesystem path under the cache-memory directory, preventing false missing_data reports with reason: cache_memory_miss when cache restore succeeds.

Changes:

  • Updated the workflow prompt to read/write exploration history via /tmp/gh-aw/cache-memory/agent-persona-explorer/explored-personas.json.
  • Clarified cache-miss semantics from “key does not exist” to “file does not exist”.
  • Recompiled the generated workflow lock file so the runtime-imported prompt content hash matches the source markdown.
Show a summary per file
File Description
.github/workflows/agent-persona-explorer.md Updates cache-memory history instructions to use a concrete on-disk JSON path and clearer existence semantics.
.github/workflows/agent-persona-explorer.lock.yml Syncs compiled metadata/body hash to the updated markdown prompt (runtime-import remains).

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Low

@github-actions

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.82.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants