Skip to content

Extend windows-cli-integration scenario matrix: add cmd/direct and path-launch for non-default shells#42622

Merged
pelikhan merged 3 commits into
mainfrom
copilot/windows-integration-improve-scenario-matrix
Jul 1, 2026
Merged

Extend windows-cli-integration scenario matrix: add cmd/direct and path-launch for non-default shells#42622
pelikhan merged 3 commits into
mainfrom
copilot/windows-integration-improve-scenario-matrix

Conversation

Copilot AI commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

The scenario matrix in windows-cli-integration.yml had two gaps: cmd lacked a direct launch scenario, and three PowerShell variants (pwsh-noprofile, powershell-default, powershell-noprofile) had no path-launch coverage. This made the shell × launch-mode matrix incomplete.

Changes

  • windows-cli-integration.yml — adds 4 entries to $scenarioMatrix:
    • cmd/direct/default/default — covers absolute-path invocation from cmd.exe (the common batch-script pattern)
    • pwsh-noprofile/path/default/workspace-first
    • powershell-default/path/default/workspace-first
    • powershell-noprofile/path/default/workspace-first

All five shells now cover both direct and path launch modes. No new dispatch logic was needed — the existing switch ($scenario.shell) / switch ($scenario.launch) branches already handle these combinations.

@{ name = "cmd/direct/default/default";                        shell = "cmd";                launch = "direct"; env = "default"; path = "default" },
@{ name = "pwsh-noprofile/path/default/workspace-first";       shell = "pwsh-noprofile";     launch = "path";   env = "default"; path = "workspace-first" },
@{ name = "powershell-default/path/default/workspace-first";   shell = "powershell-default"; launch = "path";   env = "default"; path = "workspace-first" },
@{ name = "powershell-noprofile/path/default/workspace-first"; shell = "powershell-noprofile"; launch = "path"; env = "default"; path = "workspace-first" },

Copilot AI and others added 2 commits July 1, 2026 03:57
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Add cmd/direct scenario to windows integration matrix Extend windows-cli-integration scenario matrix: add cmd/direct and path-launch for non-default shells Jul 1, 2026
Copilot AI requested a review from pelikhan July 1, 2026 04:01
@pelikhan pelikhan marked this pull request as ready for review July 1, 2026 04:06
Copilot AI review requested due to automatic review settings July 1, 2026 04:06
@pelikhan pelikhan merged commit 8e789fd into main Jul 1, 2026
@pelikhan pelikhan deleted the copilot/windows-integration-improve-scenario-matrix branch July 1, 2026 04:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the Windows CLI integration workflow’s shell × launch-mode scenario matrix to cover previously missing combinations, and also adjusts checkout behavior in the agentics maintenance workflow.

Changes:

  • Add a cmd direct launch scenario to complete coverage for cmd.exe absolute-path invocation.
  • Add path launch scenarios for pwsh-noprofile, powershell-default, and powershell-noprofile to complete coverage for PowerShell variants.
  • Set clean: false on several actions/checkout steps in agentics-maintenance.yml (not currently described in the PR metadata).
Show a summary per file
File Description
.github/workflows/windows-cli-integration.yml Adds missing scenarios to make the Windows shell × launch-mode matrix more complete.
.github/workflows/agentics-maintenance.yml Changes checkout configuration by adding clean: false in multiple sparse checkouts.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Low

Comment on lines 106 to +110
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
sparse-checkout: |
actions
clean: false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[windows-integration] Improve windows integration scenario matrix: add cmd/direct and path-launch for non-default shells

3 participants