Extend windows-cli-integration scenario matrix: add cmd/direct and path-launch for non-default shells#42622
Merged
pelikhan merged 3 commits intoJul 1, 2026
Conversation
3 tasks
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add cmd/direct scenario to windows integration matrix
Extend windows-cli-integration scenario matrix: add cmd/direct and path-launch for non-default shells
Jul 1, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the Windows CLI integration workflow’s shell × launch-mode scenario matrix to cover previously missing combinations, and also adjusts checkout behavior in the agentics maintenance workflow.
Changes:
- Add a
cmddirect launch scenario to complete coverage forcmd.exeabsolute-path invocation. - Add path launch scenarios for
pwsh-noprofile,powershell-default, andpowershell-noprofileto complete coverage for PowerShell variants. - Set
clean: falseon severalactions/checkoutsteps inagentics-maintenance.yml(not currently described in the PR metadata).
Show a summary per file
| File | Description |
|---|---|
.github/workflows/windows-cli-integration.yml |
Adds missing scenarios to make the Windows shell × launch-mode matrix more complete. |
.github/workflows/agentics-maintenance.yml |
Changes checkout configuration by adding clean: false in multiple sparse checkouts. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Low
Comment on lines
106
to
+110
| uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0 | ||
| with: | ||
| sparse-checkout: | | ||
| actions | ||
| clean: false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scenario matrix in
windows-cli-integration.ymlhad two gaps:cmdlacked adirectlaunch scenario, and three PowerShell variants (pwsh-noprofile,powershell-default,powershell-noprofile) had nopath-launch coverage. This made the shell × launch-mode matrix incomplete.Changes
windows-cli-integration.yml— adds 4 entries to$scenarioMatrix:cmd/direct/default/default— covers absolute-path invocation fromcmd.exe(the common batch-script pattern)pwsh-noprofile/path/default/workspace-firstpowershell-default/path/default/workspace-firstpowershell-noprofile/path/default/workspace-firstAll five shells now cover both
directandpathlaunch modes. No new dispatch logic was needed — the existingswitch ($scenario.shell)/switch ($scenario.launch)branches already handle these combinations.