Strengthen codemod registry coverage by asserting all registered IDs#43008
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Great work closing the codemod registry coverage gap! Expanding The PR is tightly scoped to a single test file, carries a clear description of what changed and why, introduces no new dependencies, and the change is purely additive. This looks ready for review.
|
There was a problem hiding this comment.
Pull request overview
This pull request strengthens test coverage for the GetAllCodemods() registry by expanding the TestGetAllCodemods_ContainsExpectedCodemods assertion list so it enumerates all currently-registered codemod IDs, reducing the risk of silent deletions from the registry.
Changes:
- Expanded the
expectedIDslist to include 20 codemod IDs that were already present in the registry but previously unasserted by this test. - Kept changes scoped to test-only coverage assertions (no production registry or codemod logic changes).
Show a summary per file
| File | Description |
|---|---|
| pkg/cli/fix_codemods_test.go | Expands the expected codemod ID assertion list to cover the full codemod registry. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Low
| "mcp-network-to-top-level-migration", | ||
| "add-comment-discussion-removal", | ||
| "discussion-trigger-categories-lowercase", | ||
| "mcp-mode-to-type-migration", | ||
| "install-script-url-migration", |
TestGetAllCodemods_ContainsExpectedCodemodscovered only 42 IDs while the registry now contains 62 codemods, leaving silent-deletion risk for ~32% of entries. This update closes that gap by asserting the full expected ID set.What changed
expectedIDsinpkg/cli/fix_codemods_test.goto include the 20 missing codemod IDs already present in the registry/order contract.Coverage gap removed