compilerenv: remove constructor panic to satisfy custom Go lint

[Copilot]

The CGO workflow failed in golint-custom because pkg/workflow/compilerenv/manager.go used a panic in library code (New(nil)). This change removes that failure mode and keeps constructor behavior safe under nil injection.

• Problem surfaced by CI

  • New(getenv EnvGetter) panicked on nil, violating the repository lint rule: “avoid panic in library code; return an error instead”.

• Behavior change

  • New(nil) now falls back to os.Getenv instead of panicking.
  • This preserves a valid Manager instance even when caller injection is omitted.

• Test updates

  • Replaced panic expectation with a behavioral test that verifies New(nil) reads process env values via ResolveDefaultMaxTurns.

func New(getenv EnvGetter) *Manager {
	if getenv == nil {
		getenv = os.Getenv
	}
	return &Manager{getenv: getenv}
}

[Copilot]

Pull request overview

This PR updates the compilerenv package constructor to avoid panicking on nil injection (to satisfy the repo’s “no panic in library code” lint rule), and adjusts tests accordingly. It also includes a broad regeneration of workflow .lock.yml files that bumps the gh-aw-firewall image/tag from 0.27.20 to 0.27.22.

Changes:

• Replace panic in compilerenv.New(nil) with a safe fallback to os.Getenv.
• Update the unit test to assert the new New(nil) behavior via ResolveDefaultMaxTurns.
• Regenerate multiple workflow lockfiles, updating embedded firewall image/tag/version references (0.27.20 → 0.27.22).

Show a summary per file

File	Description
pkg/workflow/compilerenv/manager.go	Removes constructor panic; New(nil) now falls back to os.Getenv.
pkg/workflow/compilerenv/manager_test.go	Updates test coverage to validate the new nil-constructor behavior.
.github/workflows/test-workflow.lock.yml	Regenerated lockfile with firewall image/tag bump to 0.27.22.
.github/workflows/smoke-opencode.lock.yml	Regenerated lockfile with firewall image/tag bump to 0.27.22.
.github/workflows/smoke-crush.lock.yml	Regenerated lockfile with firewall image/tag bump to 0.27.22.
.github/workflows/smoke-antigravity.lock.yml	Regenerated lockfile with firewall image/tag bump to 0.27.22.
.github/workflows/firewall.lock.yml	Regenerated lockfile with firewall image/tag bump to 0.27.22.
.github/workflows/example-permissions-warning.lock.yml	Regenerated lockfile with firewall image/tag bump to 0.27.22.
.github/workflows/daily-max-ai-credits-test.lock.yml	Regenerated lockfile with firewall image/tag bump to 0.27.22.
.github/workflows/daily-malicious-code-scan.lock.yml	Regenerated lockfile with firewall image/tag bump to 0.27.22.
.github/workflows/codex-github-remote-mcp-test.lock.yml	Regenerated lockfile with firewall image/tag bump to 0.27.22.
.github/workflows/bot-detection.lock.yml	Regenerated lockfile with firewall image/tag bump to 0.27.22.
.github/workflows/agentic-token-optimizer.lock.yml	Regenerated lockfile with firewall image/tag bump to 0.27.22.
.github/workflows/ace-editor.lock.yml	Regenerated lockfile with firewall image/tag bump to 0.27.22.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 41/260 changed files
• Comments generated: 2
• Review effort level: Low