Skip to content

Update package specs for modelsdev, console, and logger#44047

Merged
pelikhan merged 3 commits into
mainfrom
copilot/specification-audit-2026-07-07
Jul 7, 2026
Merged

Update package specs for modelsdev, console, and logger#44047
pelikhan merged 3 commits into
mainfrom
copilot/specification-audit-2026-07-07

Conversation

Copilot AI commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

The package spec audit found drift between implementation and package READMEs: pkg/modelsdev was missing two exported helpers, and pkg/console / pkg/logger had stale dependency sections. This PR brings the package specs back in sync with the current code.

  • Document modelsdev public API

    • Add NormalizeProvider and NormalizeComparableModelID to pkg/modelsdev/README.md
    • Capture the actual normalization contract already implemented by the package
  • Correct package dependency specs

    • Add colorwriter and stringutil to pkg/console/README.md
    • Add colorwriter to pkg/logger/README.md
  • Back the new API docs with spec tests

    • Add focused pkg/modelsdev/spec_test.go coverage for:
      • provider alias normalization (github, copilot, github_modelsgithub-copilot)
      • comparable model ID normalization (., _, case, and surrounding whitespace)
NormalizeProvider("GITHUB_MODELS")          // "github-copilot"
NormalizeComparableModelID(" GPT_4.1_mini ") // "gpt-4-1-mini"

Copilot AI and others added 2 commits July 7, 2026 14:17
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix specification audit issues identified on 2026-07-07 Update package specs for modelsdev, console, and logger Jul 7, 2026
Copilot AI requested a review from pelikhan July 7, 2026 14:20
@pelikhan pelikhan marked this pull request as ready for review July 7, 2026 14:27
Copilot AI review requested due to automatic review settings July 7, 2026 14:27
@pelikhan pelikhan merged commit 2e9b3b7 into main Jul 7, 2026
1 check passed
@pelikhan pelikhan deleted the copilot/specification-audit-2026-07-07 branch July 7, 2026 14:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates package “spec” READMEs to match the current exported surface area and dependencies, and adds spec tests for pkg/modelsdev normalization helpers. It also introduces a repeated “best-effort permission fix” step across a large number of workflow .lock.yml files to make firewall sandbox artifacts/logs readable for upload.

Changes:

  • Document pkg/modelsdev public helpers (NormalizeProvider, NormalizeComparableModelID) and add spec tests asserting the documented normalization behavior.
  • Refresh internal dependency lists in pkg/console and pkg/logger READMEs.
  • Add a chmod -R a+rX /tmp/gh-aw/sandbox/firewall ... pre-step before “Print firewall logs” across many workflow lockfiles.
Show a summary per file
File Description
pkg/modelsdev/spec_test.go Adds spec tests for provider alias normalization and comparable model ID normalization.
pkg/modelsdev/README.md Documents NormalizeProvider and NormalizeComparableModelID in the public API table.
pkg/console/README.md Updates internal dependency list to include colorwriter and stringutil.
pkg/logger/README.md Updates internal dependency list to include colorwriter.
.github/workflows/ab-testing-advisor.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/ace-editor.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/agent-performance-analyzer.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/agent-persona-explorer.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/agentic-token-audit.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/agentic-token-optimizer.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/agentic-token-trend-audit.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/ai-moderator.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/api-consumption-report.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/approach-validator.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/architecture-guardian.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/archie.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/artifacts-summary.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/audit-workflows.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/auto-triage-issues.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/avenger.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/aw-failure-investigator.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/blog-auditor.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/bot-detection.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/brave.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/breaking-change-checker.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/chaos-pr-bundle-fuzzer.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/changeset.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/ci-coach.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/ci-doctor.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/claude-code-user-docs-review.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/cloclo.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/cli-consistency-checker.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/cli-version-checker.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/code-scanning-fixer.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/code-simplifier.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/codex-github-remote-mcp-test.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/commit-changes-analyzer.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/contribution-check.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/copilot-agent-analysis.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/copilot-centralization-drilldown.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/copilot-centralization-optimizer.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/copilot-cli-deep-research.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/copilot-opt.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/copilot-pr-merged-report.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/copilot-pr-nlp-analysis.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/copilot-pr-prompt-analysis.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/copilot-session-insights.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/constraint-solving-potd.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/craft.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-agent-of-the-day-blog-writer.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-agentrx-trace-optimizer.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-ambient-context-optimizer.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-architecture-diagram.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-assign-issue-to-user.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-aw-cross-repo-compile-check.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-awf-spec-compiler-surfacing.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-byok-ollama-test.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-cache-strategy-analyzer.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-caveman-optimizer.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-choice-test.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-cli-performance.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-cli-tools-tester.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-code-metrics.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-community-attribution.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-compiler-quality.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-compiler-threat-spec-optimizer.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-credit-limit-test.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-doc-healer.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-doc-updater.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-experiment-report.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-fact.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-file-diet.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-firewall-report.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-formal-spec-verifier.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-function-namer.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-geo-optimizer.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-hippo-learn.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-issues-report.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-malicious-code-scan.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-max-ai-credits-test.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-mcp-concurrency-analysis.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-model-inventory.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-model-resolution.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-multi-device-docs-tester.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-news.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-observability-report.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-performance-summary.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-regulatory.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-rendering-scripts-verifier.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-reliability-review.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-repo-chronicle.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-safe-output-integrator.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-safe-output-optimizer.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-safe-outputs-conformance.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-safeoutputs-git-simulator.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-security-observability.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-security-red-team.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-semgrep-scan.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-secrets-analysis.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-sentrux-report.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-skill-optimizer.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-spdd-spec-planner.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-syntax-error-quality.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-team-evolution-insights.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-team-status.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-testify-uber-super-expert.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-token-consumption-report.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-windows-terminal-integration-builder.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-workflow-updater.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/daily-yamllint-fixer.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/dead-code-remover.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/deep-report.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/deployment-incident-monitor.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/dependabot-burner.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/dependabot-go-checker.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/dependabot-repair.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/designer-drift-audit.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/detection-analysis-report.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/dev-hawk.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/dev.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/dictation-prompt.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/discussion-task-miner.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/docs-noob-tester.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/draft-pr-cleanup.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/duplicate-code-detector.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/eslint-miner.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/eslint-monster.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/eslint-refiner.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/example-failure-category-filter.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/example-permissions-warning.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/example-workflow-analyzer.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/firewall-escape.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/firewall.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/functional-pragmatist.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/glossary-maintainer.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/go-fan.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/go-logger.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/go-pattern-detector.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/gpclean.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/grumpy-reviewer.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/github-mcp-structural-analysis.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/github-mcp-tools-report.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/github-remote-mcp-auth-test.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/hippo-embed.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/hourly-ci-cleaner.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/impeccable-skills-reviewer.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/instructions-janitor.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/issue-arborist.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/issue-monster.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/issue-triage-agent.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/jsweep.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/layout-spec-maintainer.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/lint-monster.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/linter-miner.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/lockfile-stats.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/mattpocock-skills-reviewer.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/mcp-inspector.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/mergefest.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/metrics-collector.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/necromancer.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/notion-issue-summary.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/objective-impact-report.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/org-health-report.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/outcome-collector.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/pdf-summary.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/plan.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/poem-bot.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/portfolio-analyst.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/pr-code-quality-reviewer.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/pr-description-caveman.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/pr-nitpick-reviewer.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/pr-sous-chef.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/pr-triage-agent.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/prompt-clustering-analysis.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/python-data-charts.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/q.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/refactoring-cadence.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/refiner.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/release.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/repo-audit-analyzer.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/repo-tree-map.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/repository-quality-improver.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/research.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/ruflo-backed-task.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/safe-output-health.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/schema-consistency-checker.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/schema-feature-coverage.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/scout.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/security-compliance.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/security-review.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/semantic-function-refactor.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/sergo.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/skillet.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/slide-deck-maintainer.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/smoke-agent-all-merged.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/smoke-agent-all-none.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/smoke-agent-public-approved.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/smoke-agent-public-none.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/smoke-agent-scoped-approved.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/smoke-antigravity.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/smoke-call-workflow.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/smoke-claude-on-copilot.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/smoke-claude.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/smoke-codex.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/smoke-copilot-arm.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/smoke-copilot-aoai-apikey.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/smoke-copilot-aoai-entra.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/smoke-copilot-sdk.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/smoke-copilot-sub-agents.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/smoke-copilot.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/smoke-create-cross-repo-pr.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/smoke-crush.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/smoke-ci.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/smoke-gemini.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/smoke-multi-pr.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/smoke-opencode.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/smoke-otel-backends.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/smoke-pi.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/smoke-project.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/smoke-service-ports.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/smoke-temporary-id.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/smoke-test-tools.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/smoke-update-cross-repo-pr.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/smoke-workflow-call-with-inputs.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/smoke-workflow-call.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/spec-enforcer.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/spec-extractor.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/spec-librarian.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/static-analysis-report.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/stale-pr-cleanup.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/stale-repo-identifier.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/step-name-alignment.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/sub-issue-closer.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/super-linter.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/technical-doc-writer.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/terminal-stylist.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/test-create-pr-error-handling.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/test-dispatcher.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/test-project-url-default.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/test-quality-sentinel.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/test-workflow.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/tidy.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/typist.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/ubuntu-image-analyzer.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/uk-ai-operational-resilience.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/unbloat-docs.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/update-astro.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/video-analyzer.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/visual-regression-checker.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/weekly-blog-post-writer.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/weekly-editors-health-check.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/weekly-issue-summary.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/weekly-safe-outputs-spec-review.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/workflow-generator.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/workflow-health-manager.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/workflow-normalizer.lock.yml Adds best-effort chmod step before firewall log summary/upload.
.github/workflows/workflow-skill-extractor.lock.yml Adds best-effort chmod step before firewall log summary/upload.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 262/262 changed files
  • Comments generated: 2
  • Review effort level: Low

Comment on lines +1011 to +1012
# Best-effort permission fix for artifact upload (AWF cleanup may not have run)
sudo -n chmod -R a+rX /tmp/gh-aw/sandbox/firewall 2>/dev/null || chmod -R a+rX /tmp/gh-aw/sandbox/firewall 2>/dev/null || true
Comment on lines +937 to +938
# Best-effort permission fix for artifact upload (AWF cleanup may not have run)
sudo -n chmod -R a+rX /tmp/gh-aw/sandbox/firewall 2>/dev/null || chmod -R a+rX /tmp/gh-aw/sandbox/firewall 2>/dev/null || true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[spec-librarian] Specification Audit — 2026-07-07 — 3 issues found

3 participants