refactor: unify parser log JavaScript files and remove duplicate code#4886
Merged
Conversation
… unused imports - Import truncateString, estimateTokens, formatDuration from log_parser_shared.cjs - Remove duplicate function definitions from parse_codex_log.cjs - Update tests to import shared utilities from log_parser_shared.cjs - Clean up unused imports in parse_claude_log.cjs and parse_copilot_log.cjs - Update log_parser_shared.cjs comment to include parse_codex_log.cjs Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Unify and remove duplicate code in parser log files
refactor: unify parser log JavaScript files and remove duplicate code
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate duplicate utility functions across log parser files into the shared module.
Changes
parse_codex_log.cjs: ImporttruncateString,estimateTokens,formatDurationfromlog_parser_shared.cjsinstead of defining locallyparse_claude_log.cjs/parse_copilot_log.cjs: Remove unused imports (formatDuration,formatBashCommand,truncateString,estimateTokens,formatMcpName,formatMcpParameters)parse_codex_log.test.cjs: Update imports to use shared module for utility functionsBefore/After
All three parsers now follow consistent architecture: bootstrap entry → shared utilities → engine-specific logic.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/user/usr/bin/gh gh api user --jq .login(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.