Skip to content

refactor: unify parser log JavaScript files and remove duplicate code#4886

Merged
pelikhan merged 2 commits into
mainfrom
copilot/remove-duplicate-code-logs
Nov 26, 2025
Merged

refactor: unify parser log JavaScript files and remove duplicate code#4886
pelikhan merged 2 commits into
mainfrom
copilot/remove-duplicate-code-logs

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Nov 26, 2025

Consolidate duplicate utility functions across log parser files into the shared module.

Changes

  • parse_codex_log.cjs: Import truncateString, estimateTokens, formatDuration from log_parser_shared.cjs instead of defining locally
  • parse_claude_log.cjs / parse_copilot_log.cjs: Remove unused imports (formatDuration, formatBashCommand, truncateString, estimateTokens, formatMcpName, formatMcpParameters)
  • parse_codex_log.test.cjs: Update imports to use shared module for utility functions

Before/After

// Before: parse_codex_log.cjs
const { runLogParser } = require("./log_parser_bootstrap.cjs");

function estimateTokens(text) { /* duplicate */ }
function formatDuration(ms) { /* duplicate */ }
function truncateString(str, maxLength) { /* duplicate */ }

// After: parse_codex_log.cjs
const { runLogParser } = require("./log_parser_bootstrap.cjs");
const { truncateString, estimateTokens, formatDuration } = require("./log_parser_shared.cjs");

All three parsers now follow consistent architecture: bootstrap entry → shared utilities → engine-specific logic.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/user
    • Triggering command: /usr/bin/gh gh api user --jq .login (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

Inspect the parser log JavaScript files and unify/remove duplicate code as much possible. Provide a unify way to render agent logs.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

… unused imports

- Import truncateString, estimateTokens, formatDuration from log_parser_shared.cjs
- Remove duplicate function definitions from parse_codex_log.cjs
- Update tests to import shared utilities from log_parser_shared.cjs
- Clean up unused imports in parse_claude_log.cjs and parse_copilot_log.cjs
- Update log_parser_shared.cjs comment to include parse_codex_log.cjs

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Unify and remove duplicate code in parser log files refactor: unify parser log JavaScript files and remove duplicate code Nov 26, 2025
Copilot AI requested a review from pelikhan November 26, 2025 21:53
@pelikhan pelikhan marked this pull request as ready for review November 26, 2025 22:22
@pelikhan pelikhan merged commit 49a7e98 into main Nov 26, 2025
84 of 85 checks passed
@pelikhan pelikhan deleted the copilot/remove-duplicate-code-logs branch November 26, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants