Skip to content

fix: resolve linting issues for sandbox feature#4887

Merged
Mossaka merged 2 commits intomossaka/srtfrom
copilot/sub-pr-4295
Nov 26, 2025
Merged

fix: resolve linting issues for sandbox feature#4887
Mossaka merged 2 commits intomossaka/srtfrom
copilot/sub-pr-4295

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Nov 26, 2025

Fixes compilation errors after enableFirewallByDefaultForCopilot signature changed to include *SandboxConfig parameter.

Changes

  • firewall_default_enablement_test.go: Add missing third argument (nil) to three test call sites
  • sandbox.go: Remove unused getSandboxConfig function

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI self-assigned this Nov 26, 2025
…d sandbox.go

Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
Copilot AI changed the title [WIP] Add new sandbox for copilot with sandbox-runtime support fix: resolve linting issues for sandbox feature Nov 26, 2025
Copilot AI requested a review from Mossaka November 26, 2025 21:43
@Mossaka Mossaka marked this pull request as ready for review November 26, 2025 21:49
@Mossaka Mossaka merged commit 19c9cda into mossaka/srt Nov 26, 2025
@Mossaka Mossaka deleted the copilot/sub-pr-4295 branch November 26, 2025 21:49
Mossaka added a commit that referenced this pull request Nov 26, 2025
…time (#4295)

* feat(sandbox): add Sandbox Runtime (SRT) support for Copilot engine

Add support for Anthropic's Sandbox Runtime as an alternative sandboxing
mechanism for Copilot-based agentic workflows.

Key changes:
- Add new sandbox types: 'default' (AWF) and 'sandbox-runtime' (SRT)
- Add SRT configuration parsing from workflow frontmatter
- Generate SRT wrapper script that initializes sandbox and passes env vars
- Fix: Remove GITHUB_TOKEN and GH_TOKEN from SRT exports to prevent
  interference with COPILOT_GITHUB_TOKEN authentication
- Fix: Normalize nil slices to empty slices for proper JSON serialization

The SRT sandbox uses bubblewrap to create isolated environments with
configurable network and filesystem restrictions.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* test(srt): add smoke tests for Sandbox Runtime integration

Add smoke test workflows to validate SRT functionality:
- smoke-srt.md: Basic SRT smoke test using compiled workflow
- smoke-srt-custom-config.md: SRT test with custom configuration
- smoke-isolated-srt.yml: Hand-written SRT test for isolated testing
- smoke-copilot-no-firewall.md: Copilot test without firewall

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* fix: resolve linting issues for sandbox feature (#4887)

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants