Remove create-discussion feature and all associated files

[Copilot]

This PR completely removes the create-discussion feature from the gh-aw repository as requested. The feature allowed agentic workflows to automatically create GitHub discussions as safe outputs, but it has been identified for removal.

Changes Made

Core Implementation Removal

• JavaScript files: Removed pkg/workflow/js/create_discussion.cjs and pkg/workflow/js/create_discussion.test.cjs
• Go integration: Removed CreateDiscussionsConfig struct, buildCreateOutputDiscussionJob function, and parseDiscussionsConfig function from the compiler
• Embed declarations: Removed createDiscussionScript variable and embed directive from js.go

Schema and Configuration Cleanup

• JSON schemas: Removed create-discussion entries from both main_workflow_schema.json and agent-output.json
• Validation logic: Removed create-discussion validation from collect_ndjson_output.cjs
• Test cases: Removed all create-discussion related test cases from Go and JavaScript test suites

Documentation Updates

• Safe outputs documentation: Removed the entire "New Discussion Creation" section from docs/safe-outputs.md
• Example workflows: Updated test-safe-outputs-custom-engine.md to remove create-discussion configuration and generation step
• CLI templates: Removed create-discussion example from pkg/cli/templates/instructions.md
• Frontmatter docs: Removed discussion-related concurrency documentation from docs/frontmatter.md

Concurrency Logic Cleanup

• Removed functions: Eliminated isDiscussionWorkflow function and all discussion-related concurrency handling
• Simplified logic: Cleaned up concurrency group key generation to remove discussion-specific branches
• Test cleanup: Removed discussion workflow test cases from concurrency tests

Verification

• ✅ All Go tests pass (go test ./...)
• ✅ Build succeeds without errors (make build)
• ✅ Linting passes (golangci-lint run)
• ✅ No remaining references to create-discussion, Discussion, or CreateDiscussion found in codebase
• ✅ CLI functionality verified (./gh-aw --help, ./gh-aw version)

The removal is complete and surgical - no other safe-output types or functionality has been affected. The codebase now operates cleanly without any create-discussion capabilities while maintaining full functionality for all other features.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• api.contoso.com
  • Triggering command: /tmp/go-build2656728407/b278/cli.test -test.testlogfile=/tmp/go-build2656728407/b278/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true (dns block)
  • Triggering command: /tmp/go-build3189086267/b278/cli.test -test.testlogfile=/tmp/go-build3189086267/b278/testlog.txt -test.paniconexit0 -test.timeout=10m0s (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

---

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.