Skip to content

Add required "type": "http" field to safe-inputs MCP configuration#5729

Merged
pelikhan merged 4 commits intomainfrom
copilot/investigate-safeinputs-server-issue
Dec 7, 2025
Merged

Add required "type": "http" field to safe-inputs MCP configuration#5729
pelikhan merged 4 commits intomainfrom
copilot/investigate-safeinputs-server-issue

Conversation

Copy link
Contributor

Copilot AI commented Dec 7, 2025 •
edited by agentic-workflows-dev bot
Loading

Claude agent fails to start with "Invalid MCP configuration:" error due to missing "type": "http" field in safe-inputs MCP server configuration.

Changes

  • pkg/workflow/safe_inputs.go: Remove conditional that only added "type": "http" for Copilot. MCP spec requires this field for HTTP transport regardless of engine.

  • pkg/workflow/safe_inputs_http_integration_test.go: Update health check assertions to reflect that /health endpoint doesn't require authentication.

Example

Before (Claude config missing type field):

{
  "safeinputs": {
    "url": "http://localhost:$PORT",
    "headers": { "Authorization": "Bearer $KEY" }
  }
}

After (type field present for all engines):

{
  "safeinputs": {
    "type": "http",
    "url": "http://localhost:$PORT",
    "headers": { "Authorization": "Bearer $KEY" }
  }
}

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/githubnext/gh-aw/actions/artifacts/4789178584/zip
    • Triggering command: /usr/bin/curl curl -L -o safeinputs.zip REDACTED -H Authorization: Bearer -H Accept: application/vnd.github+json (http block)
  • https://api.github.com/repos/githubnext/gh-aw/actions/artifacts/4789178626/zip
    • Triggering command: /usr/bin/curl curl -L REDACTED -H Authorization: Bearer -H Accept: application/vnd.github+json -o agent-stdio.zip (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

Investigate issue with safeinputs server. See https://github.com/githubnext/gh-aw/actions/runs/20001701919/job/57357936705#step:27:1

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Smoke Test Summary

  • Timestamp: 2025-12-07T12:54:46Z
  • Status: PASS
  • All tests validated: GitHub MCP, file operations, bash tools, and Playwright browser automation

AI generated by Smoke Copilot No Firewall

Changeset

AI generated by Changeset Generator

Copilot AI and others added 2 commits December 7, 2025 09:05
@pelikhan
Fix safe-inputs MCP server missing type field for Claude
a3d14e6 
The safe-inputs MCP server HTTP configuration was missing the required
"type": "http" field for Claude engine. The MCP specification requires
this field for HTTP transport. This was causing Claude to fail with
"Invalid MCP configuration:" error when trying to load the MCP configuration.

The fix ensures that the "type": "http" field is always included in the
safe-inputs MCP configuration, regardless of the engine.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@pelikhan
Update safe-inputs HTTP tests for health endpoint without auth
1e62ee4 
The health endpoint (/health) for the safe-inputs MCP server doesn't
require authentication, so the tests should check for the correct
health check command without Authorization headers.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Investigate issue with safeinputs server Add required "type": "http" field to safe-inputs MCP configuration Dec 7, 2025
Copilot AI requested a review from pelikhan December 7, 2025 09:20
@pelikhan pelikhan added the smoke label Dec 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025

🔮 The ancient spirits stir... Smoke Codex awakens to divine this pull request...

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025

📰 BREAKING: Smoke Copilot Playwright is now investigating this pull request. Sources say the story is developing...

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025

💥 WHOOSH! Smoke Claude springs into action on this pull request! [Panel 1 begins...]

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025

📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing...

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025

🤖 SYSTEM_INIT: Smoke Copilot No Firewall ACTIVATED. PROCESSING pull request. ALL SUBSYSTEMS ONLINE.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025 •
edited by agentic-workflows-dev bot
Loading

🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025

✅ Dev Hawk Report - Success

Workflow Run: #3053

  • Status: ✅ completed
  • Conclusion: ✅ success
  • Duration: ~1.5 minutes (95 seconds)
  • Commit: 1e62ee4
  • Branch: copilot/investigate-safeinputs-server-issue

The Dev workflow completed successfully! 🎉

All checks passed for the changes to safe-inputs MCP configuration and HTTP test updates.

🦅 Observed from above by Dev Hawk

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025

Smoke Test Results

GitHub MCP: ✅ (#5737: Close entity refactoring, #5727: Add health GET endpoint)
File Writing: ✅ Created test file successfully
Bash Tool: ✅ Verified file contents
Playwright MCP: ✅ GitHub page title verified

Overall Status: PASS

🤖 DIAGNOSTIC REPORT GENERATED BY Smoke Copilot No Firewall fer issue #5729 🗺️

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025

Smoke Test Results

PR #5726: Store safeinputs MCP server logs in artifact and add health endpoint
PR #5737: Close entity refactoring already complete - validation only

✅ GitHub MCP: Last 2 PRs retrieved
✅ File Writing: Test file created successfully
✅ Bash Tool: File verified with cat
❌ Default Toolset: get_me correctly NOT available (tool not found error expected)

Overall: PASS

📰 BREAKING: Report filed by Smoke Copilot fer issue #5729 🗺️

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025

Smoke Test Results - Claude Engine (20004506330)

Last 2 Merged PRs:

Test Results:
✅ GitHub MCP - Retrieved recent PRs
✅ File Writing - Created test file successfully
✅ Bash Tool - Verified file contents
✅ Playwright MCP - Navigated to GitHub, title contains "GitHub"

Overall: PASS

💥 [THE END] — Illustrated by Smoke Claude fer issue #5729 🗺️

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025

Smoke Test Results

✅ Playwright MCP: Navigated to https://github.com and verified page title contains "GitHub"

Overall Status: PASS

📰 BREAKING: Report filed by Smoke Copilot Playwright fer issue #5729 🗺️

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025

Merged PRs: Store safeinputs MCP server logs in artifact and add health endpoint; Add GET health endpoint to MCP HTTP server
GitHub MCP ✅
File write ✅
File verify ✅
Playwright title ✅
Overall: PASS

🔮 The oracle has spoken through Smoke Codex fer issue #5729 🗺️

@pelikhan pelikhan marked this pull request as ready for review December 7, 2025 12:57
@pelikhan pelikhan merged commit 21e320f into main Dec 7, 2025
5 of 6 checks passed
@pelikhan pelikhan deleted the copilot/investigate-safeinputs-server-issue branch December 7, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pelikhan pelikhan Awaiting requested review from pelikhan

Assignees

@pelikhan pelikhan

Copilot code review Copilot

Labels

smoke smoke-claude smoke-codex smoke-copilot smoke-copilot-no-firewall

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pelikhan