Fix intermittent test failure in Safe Inputs API key generation#6696
Merged
Fix intermittent test failure in Safe Inputs API key generation#6696
Conversation
Increase random bytes from 32 to 33 to ensure at least 40 characters after base64 encoding and removing special characters. This fixes the intermittent test failure where some random data resulted in only 39 characters. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issues in unit tests
Fix intermittent test failure in Safe Inputs API key generation
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
generate_safe_inputs_config.test.cjstest was failing intermittently because base64 encoding 32 random bytes and stripping special characters (/+=) produces 39-43 characters depending on the random data.Changes
generate_safe_inputs_config.cjsThis ensures the generated API key always meets the 40-character minimum while maintaining strong cryptographic entropy (264 bits).
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/user/usr/bin/gh gh api user --jq .login --abbrev-ref HEAD /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet(http block)/usr/bin/gh gh api user --jq .login --noprofile(http block)/usr/bin/gh gh api user --jq .login it/ref/tags/v5 /tmp/go-build822809793/b040/vet.cfg 17197482e2ef6f4d623065e716b7cc1b6c4/log.json(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.