[WIP] Revive JavaScript formatting and ensure stability when running multiple times#6851
Merged
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
- Add npx prefix to all prettier commands to avoid permission issues - Exclude node_modules from terser processing to prevent breaking prettier binary - JavaScript formatting now stable when run multiple times - All 2218 tests pass after formatting Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
- Remove --comments all from terser to prevent comment duplication - Add npx prefix to all prettier commands to avoid permission issues - Exclude node_modules from terser processing - JavaScript formatting now fully idempotent (3+ runs produce identical results) - All 2218 tests pass after formatting - Net result: 2,703 lines reduced, no duplicate comments Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot stopped work on behalf of
pelikhan due to an error
December 18, 2025 13:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JavaScript Formatting Stability Fix - COMPLETE ✓
make fmtruns successfully with no changes ✓Problem Summary
The JavaScript formatting pipeline had three critical issues:
prettierwas called withoutnpx, leading to permission denied errors when the binary wasn't executablenode_modules/, including prettier's own binary, removing its execute permissions--comments alloption was causing inline comments to be duplicated on each formatting runSolution
pkg/workflow/js/package.json changes:
Results
✅ Formatting is now truly idempotent
make fmtmultiple times produces identical results✅ All tests pass: 2218 tests passing
✅ Code optimization: Net reduction of 2,703 lines while maintaining readability
✅ Ready for merge: Formatting pipeline is stable and production-ready
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.