Disable sandbox.agent: false in strict mode for copilot engine
#6903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds validation to reject `sandbox.agent: false` in strict mode for the copilot engine because it disables the firewall, which is a security concern in production workflows. Changes: - Modified validateStrictFirewall to return an error when sandbox.agent: false is used with copilot engine in strict mode - Fixed strict mode re-evaluation ordering in compiler_parse.go - Updated tests to reflect the new behavior - Updated smoke workflows to use strict: false Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Disable 'sandbox: agent: false' in strict mode
Disable Dec 19, 2025
sandbox.agent: false in strict mode for copilot engine
Contributor
|
🤖 DIAGNOSTIC COMPLETE: Smoke Copilot No Firewall STATUS: ALL_UNITS_OPERATIONAL. MISSION_SUCCESS. |
Contributor
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
Contributor
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
Contributor
|
💀 Blimey! Smoke Copilot Safe Inputs failed and walked the plank! No treasure today, matey! ☠️ |
Contributor
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
Contributor
|
🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰 |
Contributor
Smoke Test ResultsLast 2 Merged PRs:
Test Results:
Overall: PASS
|
Contributor
Smoke Test Results for Run 20355906441Recent PRs:
Tests:
Status: ✅ PASS CC:
|
Contributor
|
PRs (last 2 merged):
|
Contributor
Smoke Test Results (Claude Engine)Last 2 merged PRs:
Test Results:
Overall Status: PASS (5/6 tests successful)
|
Contributor
|
@copilot strict mode should be enforced for all agents, not just copilot. |
…rict mode Per review feedback, the strict mode validation for sandbox.agent: false now applies to all engines, not just copilot. This ensures consistent security enforcement across all agent engines. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
This was referenced Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validateStrictFirewallinpkg/workflow/strict_mode_validation.goto rejectsandbox.agent: falsein strict mode for all engines (not just copilot)compiler_parse.goto ensure strict mode is properly evaluated beforevalidateStrictFirewallis calledsmoke-copilot.md,smoke-copilot-playwright.md) that usesandbox.agent: falseto setstrict: falseOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.