Simplify GenerateOutputSchema to use idiomatic For[T]() pattern#7046
Merged
Simplify GenerateOutputSchema to use idiomatic For[T]() pattern#7046
Conversation
…tern Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor GenerateOutputSchema to use For[T]() pattern
Simplify GenerateOutputSchema to use idiomatic For[T]() pattern
Dec 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
GenerateOutputSchemafunction used manual reflection indirection when the jsonschema-go library provides a cleaner genericFor[T]()function.Changes
reflect.TypeOf()indirection with directjsonschema.For[T](nil)callfmtandreflectimportsBefore/After
The
For[T]()function internally usesreflect.TypeFor[T]()which is more efficient than instantiating a zero value and callingreflect.TypeOf().Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.