Remove hour support from expires field schema pattern#7213
Merged
Conversation
- Updated main_workflow_schema.json to remove hH from pattern - Changed pattern from ^[0-9]+[hHdDwWmMyY]$ to ^[0-9]+[dDwWmMyY]$ - Updated all three locations: create-issue, create-discussion, create-pull-request - Removed '20h' from description examples - Fixed slide-deck-maintainer.md workflow to use 1d instead of 20h - Rebuilt binary with embedded schema changes - Recompiled all 120 workflow files successfully Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update expires schema pattern to remove hour support
Remove hour support from expires field schema pattern
Dec 22, 2025
pelikhan
approved these changes
Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JSON schema advertised hour support (
hH) in theexpiresfield pattern, butparseRelativeTimeSpec()only implements days, weeks, months, and years. This caused runtime failures when users tried hour-based expiration based on schema validation.Changes
Schema Updates (
pkg/parser/schemas/main_workflow_schema.json):^[0-9]+[hHdDwWmMyY]$to^[0-9]+[dDwWmMyY]$in 3 locations:create-issueexpires fieldcreate-discussionexpires fieldcreate-pull-requestexpires field'20h'from description examplesWorkflow Fix (
.github/workflows/slide-deck-maintainer.md):expires: 20htoexpires: 1dSchema validation now correctly rejects hour format:
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/user/usr/bin/gh gh api user --jq .login ithub/workflows log /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/link l GOWORK 64/bin/go /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linurev-parse -V=f�� ef/tags/v0.20.10 64/bin/go noffline l config 64/bin/go noffline(http block)/usr/bin/gh gh api user --jq .login ithub/workflows -trimpath /usr/bin/git -p main -lang=go1.25 git rev-�� ithub/workflows -dwarf=false e/git go1.25.0 -c=4 -nolocalimports e/git(http block)/usr/bin/gh gh api user --jq .login tags/v6 origin 5b03dc94af42c27294debc182334e5e4f2c/log.json te '**/*.cjs' '*infocmp node 64/bin/go git rev-�� k/gh-aw/gh-aw/.github/workflows husky e/git(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.