Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Review all JavaScript to be inserted in actions/github-script and make sure
- core.error is used instead of console.error
- core.warn is used instead of console.warn
- update all tests after changes
Replace console.error/warn with core.error/warn in JavaScript actions
Sep 11, 2025
pelikhan
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated all JavaScript code used in github-script actions to use the proper GitHub Actions core utilities (
core.errorandcore.warn) instead of console methods (console.errorandconsole.warn).Problem
JavaScript code in github-script actions was using console logging methods which don't integrate properly with GitHub Actions logging infrastructure. This means:
Changes
Files Modified:
pkg/workflow/js/collect_ndjson_output.cjs- Replacedconsole.errorwithcore.errorfor file write failurespkg/workflow/js/add_reaction_and_edit_comment.cjs- Replacedconsole.warnwithcore.warnfor comment editing failurespkg/workflow/js/collect_ndjson_output.test.cjs- Updated test expectations to match new logging behaviorExample of changes:
Benefits
Testing
core.error/core.warnusage instead of console methodsconsole.errororconsole.warnusage in production JavaScript codeThe changes are minimal and surgical - only the specific logging calls were modified while preserving all existing functionality and behavior.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
api.contoso.com/tmp/go-build485625254/b278/cli.test -test.testlogfile=/tmp/go-build485625254/b278/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true(dns block)/tmp/go-build525063829/b278/cli.test -test.testlogfile=/tmp/go-build525063829/b278/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.