Skip to content

Code review comments pt3 #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsyme merged 3 commits into from
Sep 11, 2025
Merged

Code review comments pt3 #741

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2742752
fix code review comments part 2
dsyme Sep 11, 2025
7eb81fe
giMerge branch 'main' of https://github.com/githubnext/gh-aw into crc2
dsyme Sep 11, 2025
c745e15
fix code review comment creation
dsyme Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions pkg/workflow/js/create_pr_review_comment.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,20 +78,24 @@ async function main() {
const defaultSide = process.env.GITHUB_AW_PR_REVIEW_COMMENT_SIDE || "RIGHT";
console.log(`Default comment side configuration: ${defaultSide}`);

// Check if we're in a pull request context
// Check if we're in a pull request context, or an issue comment context on a PR
const isPRContext =
context.eventName === "pull_request" ||
context.eventName === "pull_request_review" ||
context.eventName === "pull_request_review_comment";
context.eventName === "pull_request_review_comment" ||
(context.eventName === "issue_comment" &&
context.payload.issue &&
context.payload.issue.pull_request);

if (!isPRContext) {
console.log(
"Not running in pull request context, skipping review comment creation"
);
return;
}
const pullRequest = context.payload.pull_request || context.payload.issue.pull_request;

if (!context.payload.pull_request) {
if (!pullRequest) {
console.log(
"Pull request context detected but no pull request found in payload"
);
Expand All @@ -100,16 +104,16 @@ async function main() {

// Check if we have the commit SHA needed for creating review comments
if (
!context.payload.pull_request.head ||
!context.payload.pull_request.head.sha
!pullRequest.head ||
!pullRequest.head.sha
) {
console.log(
"Pull request head commit SHA not found in payload - cannot create review comments"
);
return;
}

const pullRequestNumber = context.payload.pull_request.number;
const pullRequestNumber = pullRequest.number;
console.log(`Creating review comments on PR #${pullRequestNumber}`);

const createdComments = [];
Expand Down Expand Up @@ -199,7 +203,7 @@ async function main() {
pull_number: pullRequestNumber,
body: body,
path: commentItem.path,
commit_id: context.payload.pull_request.head.sha, // Required for creating review comments
commit_id: pullRequest.head.sha, // Required for creating review comments
line: line,
side: side,
};
Expand Down