Fix firewall parser to use setupGlobals pattern#7689
Merged
pelikhan merged 2 commits intoDec 26, 2025
Merged
Conversation
- Add setupGlobals() call before requiring parse_firewall_logs.cjs - Remove parameter passing to main() function - This matches the pattern used by agent log parsers - Fixes workflow run #20515319042 failure Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix firewall parser JavaScript to use require and setup globals
Fix firewall parser to use setupGlobals pattern
Dec 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The firewall log parser step was calling
main()with parameters instead of using thesetupGlobals()pattern, causing the parser to fail when accessingcoreas a global variable.Changes
generateFirewallLogParsingStep()inpkg/workflow/copilot_srt.goto callsetupGlobals()before requiring the parser scriptmain()invocation to match agent log parser pattern (no parameters)Before
After
This aligns with how all other log parsers (Claude, Codex, Copilot) access GitHub Actions objects as globals.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.