Skip to content

Remove duplicate firewall log steps in Codex workflows#7691

Merged
pelikhan merged 3 commits into
copilot/remove-js-sh-scripts-embeddingsfrom
copilot/remove-duplicate-steps-lock-file
Dec 26, 2025
Merged

Remove duplicate firewall log steps in Codex workflows#7691
pelikhan merged 3 commits into
copilot/remove-js-sh-scripts-embeddingsfrom
copilot/remove-duplicate-steps-lock-file

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Dec 26, 2025

The compiler generated duplicate "Upload Firewall Logs" and "Parse firewall logs for step summary" steps in Codex engine workflows due to CodexEngine.GetSquidLogsSteps() being called twice in the main job generation.

Changes

  • Removed duplicate CodexEngine check in pkg/workflow/compiler_yaml_main_job.go (lines 265-272)
  • Recompiled all workflow lock files to remove duplicate steps

Impact

12 Codex-based workflows now generate correct step sequences:

  • changeset, daily-performance-summary, daily-issues-report, close-old-discussions, daily-fact, issue-arborist, duplicate-code-detector, smoke-codex, smoke-codex-firewall, deep-report

Before:

- name: Upload Firewall Logs    # step 38
- name: Parse firewall logs     # step 39
- name: Upload Firewall Logs    # step 40 (duplicate)
- name: Parse firewall logs     # step 41 (duplicate)

After:

- name: Upload Firewall Logs    # step 38
- name: Parse firewall logs     # step 39

Total: 184 lines of duplicate YAML removed across lock files.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/user
    • Triggering command: /usr/bin/gh gh api user --jq .login ithub/workflows -buildtags /usr/bin/gh -errorsas -ifaceassert -nilfunc gh api ithub/workflows --jq /usr/bin/gh (http block)
    • Triggering command: /usr/bin/gh gh api user --jq .login super-linter.git k/gh-aw/gh-aw/pkg/logger/logger.go /tmp/go-build1043129138/b382/gitutil.test (http block)
    • Triggering command: /usr/bin/gh gh api user --jq .login up-uv.git up-uv.git 9d8a3b5a4707b9ee47c0fc5304246576fb4/log.json l (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

Reference: https://github.com/githubnext/gh-aw/actions/runs/20515667290/job/58943104603

Review the generated steps in each job in the lock file and remove the duplicates (update compiler to stop generating duplicates).


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits December 26, 2025 04:16
…piler

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix duplicate steps in lock file jobs Remove duplicate firewall log steps in Codex workflows Dec 26, 2025
Copilot AI requested a review from pelikhan December 26, 2025 04:29
@pelikhan pelikhan marked this pull request as ready for review December 26, 2025 04:29
@pelikhan pelikhan merged commit e1f5b99 into copilot/remove-js-sh-scripts-embeddings Dec 26, 2025
@pelikhan pelikhan deleted the copilot/remove-duplicate-steps-lock-file branch December 26, 2025 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants