Fix staged safe outputs handling in create_pull_request.cjs#772
Merged
Fix staged safe outputs handling in create_pull_request.cjs#772
Conversation
…omprehensive tests Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Make sure https://github.com/githubnext/gh-aw/blob/main/pkg/workflow/js/create_pull_request.cjs handles staged safe outputs.
Fix staged safe outputs handling in create_pull_request.cjs
Sep 12, 2025
pelikhan
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
create_pull_request.cjsscript had incomplete staged safe outputs handling. WhenGITHUB_AW_SAFE_OUTPUTS_STAGED=true, the script would exit early for empty patches, missing patch files, or patch errors without showing users what would have happened. This left users without feedback about their workflow behavior in preview mode.Solution
This PR fixes the staged mode implementation by:
Key Changes
Enhanced Staged Mode Logic
⚠️ No patch file found⚠️ Patch file contains errorComprehensive Test Coverage
Added 7 new test cases covering:
Example Behavior
Before: Empty patch would exit silently in staged mode
After: Empty patch shows informative preview
Testing
The staged safe outputs functionality now provides complete visibility into what pull request operations would be performed, improving the user experience for workflow development and debugging.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
api.contoso.com/tmp/go-build2951451216/b278/cli.test -test.testlogfile=/tmp/go-build2951451216/b278/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true(dns block)/tmp/go-build1844766080/b278/cli.test -test.testlogfile=/tmp/go-build1844766080/b278/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.