Skip to content

Fix javascript typecheck issues#787

Merged
pelikhan merged 13 commits intomainfrom
pelikhan/cjs-fix
Sep 12, 2025
Merged

Fix javascript typecheck issues#787
pelikhan merged 13 commits intomainfrom
pelikhan/cjs-fix

Conversation

@pelikhan
Copy link
Copy Markdown
Collaborator

  • properly wired typechecking
  • fix usage of github actions apis

…pe annotations, and improve best practices documentation for GitHub Actions.
…es, noImplicitThis, and noImplicitReturns to true in tsconfig.json
- Improved error handling in Claude and Codex workflows by ensuring error messages are properly formatted and checked for instance type.
- Added JSDoc comments to various functions to enhance code documentation and maintainability, including:
  - `parseClaudeLog`
  - `formatToolUse`
  - `formatMcpName`
  - `formatMcpParameters`
  - `formatBashCommand`
  - `truncateString`
  - `parseCodexLog`
  - `validateErrors`
  - `extractLevel`
  - `extractMessage`
- Updated logging statements to use `core.info` for consistency and clarity in output.
…flow scripts

- Updated all instances of console.log to core.info for consistent logging across create_code_scanning_alert, create_comment, create_discussion, create_issue, create_pr_review_comment, create_pull_request, push_to_pr_branch, update_issue, and other workflow scripts.
- Replaced console.error with core.error for error logging in parse_claude_log and other scripts.
- Changed console.warn to core.warning where applicable to provide clearer logging semantics.
- Enhanced log messages to include more context and structured information for better traceability.
- Replaced console.log statements with core.info, core.debug, core.warning, and core.setFailed in multiple workflow files for improved logging consistency and clarity.
- Updated workflows related to safe outputs, pull requests, issue updates, and agent logs to enhance error handling and output messaging.
- Ensured that all log messages are appropriately categorized to facilitate better debugging and monitoring of workflow executions.
@pelikhan
Copy link
Copy Markdown
Collaborator Author

@copilot fix tests

Copy link
Copy Markdown
Contributor

Copilot AI commented Sep 12, 2025

@pelikhan I've opened a new pull request, #788, to work on those changes. Once the pull request is ready, I'll request review from you.

@pelikhan pelikhan enabled auto-merge (squash) September 12, 2025 16:09
@pelikhan pelikhan disabled auto-merge September 12, 2025 16:09
@pelikhan pelikhan merged commit d01264d into main Sep 12, 2025
13 of 16 checks passed
@pelikhan pelikhan deleted the pelikhan/cjs-fix branch September 12, 2025 16:09
dsyme added a commit that referenced this pull request Sep 25, 2025
…PR inclusion (#787)

* Initial plan

* Move aw_info.json generation to /tmp directory and add cleanup step

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

* Remove cleanup step for /tmp/aw_info.json as requested

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

* update lock files

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: Don Syme <dsyme@users.noreply.github.com>
Co-authored-by: Don Syme <dsyme@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants