Skip to content

Fix ineffectual error assignments in pull request activity type tests#7883

Merged
pelikhan merged 2 commits into
mainfrom
copilot/resolve-test-issue
Dec 27, 2025
Merged

Fix ineffectual error assignments in pull request activity type tests#7883
pelikhan merged 2 commits into
mainfrom
copilot/resolve-test-issue

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Dec 27, 2025

Test issue for ProjectOps functionality verification. The linter identified unused error assignments in pull_request_activity_types_test.go where error values were assigned but never checked.

Changes

  • Fixed linting errors: Replaced unused err assignments with blank identifiers (_) in uppercase and mixed-case activity type validation tests
  • Code formatting: Applied automatic formatting to several files per repository standards
// Before (ineffectual assignment)
ir, err = ParseTriggerShorthand(trigger)

// After (intentionally discarded)
ir, _ = ParseTriggerShorthand(trigger)

The test validates that invalid casing is rejected, but doesn't need to inspect the error details, only the result structure.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/user
    • Triggering command: /usr/bin/gh gh api user --jq .login -json GO111MODULE rg/toolchain@v0.GOMODCACHE GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE rg/toolchain@v0.0.1-go1.25.0.linGOMODCACHE GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh api user --jq .login it/ref/tags/v5 --jq /home/REDACTED/go/pkg/mod/golang.o-id -json GO111MODULE ux-amd64/bin/go /home/REDACTED/go/pkg/mod/golang.oTest User -o etup-go/git/ref/tags/v6 -trimpath /usr/bin/git -p main l/linux_amd64/veget-url 5bba9dc687a71381origin (http block)
    • Triggering command: /usr/bin/gh gh api user --jq .login super-linter.git t (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>Test issue</issue_title>
<issue_description>This is a test for ProjectOps</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix test issue for ProjectOps Fix ineffectual error assignments in pull request activity type tests Dec 27, 2025
Copilot AI requested a review from mnkiefer December 27, 2025 11:13
@pelikhan pelikhan marked this pull request as ready for review December 27, 2025 15:24
@pelikhan pelikhan merged commit e0fa2d9 into main Dec 27, 2025
4 checks passed
@pelikhan pelikhan deleted the copilot/resolve-test-issue branch December 27, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test issue

3 participants