Remove @ts-nocheck from 15 .cjs files and fix type errors#7909
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix type checking in .cjs file with ts-no check
Remove @ts-nocheck from 15 .cjs files and fix type errors
Dec 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
15 JavaScript files had
@ts-nocheckdirectives disabling TypeScript type checking. All type errors have been resolved and checking is now enabled.Changes by pattern
Error handling - Replace optional chaining with proper instanceof checks:
Undefined values - Add default values or guards:
Null checks - Guard property access on nullable objects:
Type annotations - Add JSDoc where inference fails:
Dynamic properties - Use
@ts-ignorewith explanations for intentional dynamic properties on arrays/objectsFiles fixed (15)
add_copilot_reviewer.cjs, add_reviewer.cjs, assign_agent_helpers.cjs, assign_copilot_to_created_issues.cjs, assign_issue.cjs, assign_milestone.cjs, assign_to_agent.cjs, assign_to_user.cjs, check_workflow_timestamp_api.cjs, interpolate_prompt.cjs, link_sub_issue.cjs, mcp_http_transport.cjs, notify_comment_error.cjs, parse_copilot_log.cjs, safe_inputs_bootstrap.cjs
Validation
npm run typecheckpasses with zero errors.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.