Refactor MCP server configuration into centralized provider and remove deprecated RenderMCPConfig function by Copilot · Pull Request #801 · github/gh-aw

Copilot · 2025-09-12T20:14:05Z

Refactored MCP server configuration to use a centralized provider pattern and removed deprecated functions based on feedback. This PR consolidates MCP configuration logic, eliminates code duplication, and removes backward compatibility for unused functions.

Summary

Successfully addressed all feedback comments with comprehensive refactoring:

Restored user-agent generation: GitHub MCP configurations now properly compute user-agent from workflow names
Fixed API design: Added NewMCPServerConfigurationsFromFrontmatter() for cleaner single-call usage
Removed deprecated functions: Completely removed RenderMCPConfig function and all related helper functions since they were only used by tests
Centralized configuration logic: Created ComputeMCPServerConfigurationsFromFrontmatter() that handles workflow name extraction internally, eliminating code duplication in mcp_inspect.go
Updated all tests: Modified test functions to use the new RenderMCPConfigFromConfigurations() approach with proper configuration providers
Clean codebase: Removed all unused helper functions and ensured linting passes

Changes Made

Centralized MCP configuration: New ComputeMCPServerConfigurationsFromFrontmatter() function handles provider creation and workflow name extraction internally
Removed deprecated API: Eliminated RenderMCPConfig function from engine interface and all implementations
Code cleanup: Removed unused helper functions like generatePlaywrightDockerArgs, getPlaywrightDockerImageVersion, etc.
Test updates: All MCP-related tests now use the new configuration provider approach
API simplification: Reduced function parameters and cleaner call patterns throughout the codebase

The centralized MCP configuration provider now properly generates user-agent fields for Codex engine while maintaining a much cleaner and more maintainable codebase architecture.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pkg/workflow/agentic_engine.go

pkg/workflow/claude_engine.go

pkg/workflow/custom_engine.go

pkg/cli/workflows/test-claude-add-issue-comment.lock.yml

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2025-09-12T20:55:40Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

api.contoso.com
- Triggering command: /tmp/go-build2429348446/b278/cli.test -test.testlogfile=/tmp/go-build2429348446/b278/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true (dns block)
- Triggering command: /tmp/go-build1673032990/b278/cli.test -test.testlogfile=/tmp/go-build1673032990/b278/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

pkg/cli/workflows/test-codex-add-issue-comment.lock.yml

pelikhan · 2025-09-12T20:55:26Z

pkg/workflow/agentic_engine.go

@@ -48,6 +48,9 @@ type CodingAgentEngine interface {
 	// RenderMCPConfig renders the MCP configuration for this engine to the given YAML builder
 	RenderMCPConfig(yaml *strings.Builder, tools map[string]any, mcpTools []string, workflowData *WorkflowData)


@copilot is this function still used?

Yes, the RenderMCPConfig function is still used by tests and as part of the engine interface. However, the new compiler uses RenderMCPConfigFromConfigurations which leverages the centralized configuration provider. The old function remains for backward compatibility and testing. Commit: 0931e39

@copilot no backward compatibility. If only tests use this function remove.

Removed the RenderMCPConfig function completely as requested. The function was only used by tests, so I updated all tests to use the new RenderMCPConfigFromConfigurations approach with the centralized configuration provider. All tests pass. Commit: ff5125a

pkg/workflow/mcp_server_config.go

…ve API Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2025-09-12T21:16:00Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

api.contoso.com
- Triggering command: /tmp/go-build1615415865/b278/cli.test -test.testlogfile=/tmp/go-build1615415865/b278/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

pelikhan · 2025-09-12T21:19:46Z

pkg/cli/mcp_inspect.go

+	configProvider := workflow.NewMCPServerConfigProvider()
+
+	// Create minimal WorkflowData for user-agent computation
+	minimalWorkflowData := &workflow.WorkflowData{


@copilot move this logic inside of ComputeMCPServerConfigurations

Moved the logic into ComputeMCPServerConfigurations by creating ComputeMCPServerConfigurationsFromFrontmatter() that handles workflow name extraction internally. This eliminates the repetitive MCPServerConfigProvider creation and minimalWorkflowData construction. Commit: ff5125a

pelikhan · 2025-09-12T21:19:59Z

pkg/cli/mcp_inspect.go

+		configProvider := workflow.NewMCPServerConfigProvider()
+
+		// Create minimal WorkflowData for user-agent computation
+		minimalWorkflowData := &workflow.WorkflowData{


@copilot move this logic inside of ComputeMCPServerConfigurations

Moved the logic into ComputeMCPServerConfigurations by creating ComputeMCPServerConfigurationsFromFrontmatter() that handles workflow name extraction internally. This eliminates the repetitive MCPServerConfigProvider creation and minimalWorkflowData construction. Commit: ff5125a

pelikhan · 2025-09-12T21:20:09Z

pkg/cli/mcp_inspect.go

+		configProvider := workflow.NewMCPServerConfigProvider()
+
+		// Create minimal WorkflowData for user-agent computation
+		minimalWorkflowData := &workflow.WorkflowData{


@copilot move this logic inside of ComputeMCPServerConfigurations

Moved the logic into ComputeMCPServerConfigurations by creating ComputeMCPServerConfigurationsFromFrontmatter() that handles workflow name extraction internally. This eliminates the repetitive MCPServerConfigProvider creation and minimalWorkflowData construction. Commit: ff5125a

pelikhan · 2025-09-12T21:20:42Z

pkg/workflow/agentic_engine.go

@@ -48,6 +48,9 @@ type CodingAgentEngine interface {
 	// RenderMCPConfig renders the MCP configuration for this engine to the given YAML builder
 	RenderMCPConfig(yaml *strings.Builder, tools map[string]any, mcpTools []string, workflowData *WorkflowData)


@copilot no backward compatibility. If only tests use this function remove.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2025-09-12T21:41:27Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

api.contoso.com
- Triggering command: /tmp/go-build3969010265/b278/cli.test -test.testlogfile=/tmp/go-build3969010265/b278/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

…#801)

Initial plan

0e99801

Copilot AI assigned Copilot and pelikhan Sep 12, 2025

Copilot started work on behalf of pelikhan September 12, 2025 20:14 View session

Complete MCP server configuration refactor

b81a8ba

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI requested a review from pelikhan September 12, 2025 20:35

Copilot finished work on behalf of pelikhan September 12, 2025 20:35

pelikhan reviewed Sep 12, 2025

View reviewed changes

pkg/workflow/agentic_engine.go Show resolved Hide resolved

pkg/workflow/claude_engine.go Outdated Show resolved Hide resolved

pkg/workflow/custom_engine.go Outdated Show resolved Hide resolved

pkg/cli/workflows/test-claude-add-issue-comment.lock.yml Outdated Show resolved Hide resolved

Copilot started work on behalf of pelikhan September 12, 2025 20:40 View session

Copilot AI and others added 2 commits September 12, 2025 20:51

Consolidate MCP rendering and fix task job generation

cac3083

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Final validation: All changes working correctly

0931e39

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~Refactor MCP server configuration into centralized provider~~ Refactor MCP server configuration into centralized provider and fix task job generation Sep 12, 2025

Copilot AI requested a review from pelikhan September 12, 2025 20:55

Copilot finished work on behalf of pelikhan September 12, 2025 20:55

pelikhan reviewed Sep 12, 2025

View reviewed changes

Copilot started work on behalf of pelikhan September 12, 2025 20:59 View session

Fix MCP server configuration: restore user-agent generation and impro…

5f22868

…ve API Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI requested a review from pelikhan September 12, 2025 21:16

Copilot finished work on behalf of pelikhan September 12, 2025 21:16

pelikhan reviewed Sep 12, 2025

View reviewed changes

Copilot started work on behalf of pelikhan September 12, 2025 21:21 View session

Remove RenderMCPConfig function and centralize MCP provider logic

ff5125a

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pelikhan closed this Sep 12, 2025

Copilot AI changed the title ~~Refactor MCP server configuration into centralized provider and fix task job generation~~ Refactor MCP server configuration into centralized provider and remove deprecated RenderMCPConfig function Sep 12, 2025

Copilot AI requested a review from pelikhan September 12, 2025 21:41

Copilot finished work on behalf of pelikhan September 12, 2025 21:41

dsyme pushed a commit that referenced this pull request Sep 25, 2025

Add phase for searching existing issues in CI Failure Doctor workflow (…

9374acc

…#801)

Mossaka mentioned this pull request Sep 30, 2025

fix: build script now works on MacOS #1102

Closed

		@@ -48,6 +48,9 @@ type CodingAgentEngine interface {
		// RenderMCPConfig renders the MCP configuration for this engine to the given YAML builder
		RenderMCPConfig(yaml strings.Builder, tools map[string]any, mcpTools []string, workflowData WorkflowData)

Comments

Conversation

Copilot AI commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes Made

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Sep 12, 2025

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Uh oh!

Uh oh!

pelikhan Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

pelikhan Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Sep 12, 2025

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

pelikhan Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

pelikhan Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

pelikhan Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

pelikhan Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Sep 12, 2025

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Sep 12, 2025 •

edited

Loading