Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions .github/workflows/ci-doctor.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 0 additions & 10 deletions .github/workflows/dev.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 0 additions & 10 deletions pkg/cli/workflows/test-ai-inference-github-models.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 0 additions & 10 deletions pkg/cli/workflows/test-claude-add-issue-comment.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 0 additions & 10 deletions pkg/cli/workflows/test-claude-add-issue-labels.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 0 additions & 10 deletions pkg/cli/workflows/test-claude-cache-memory.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 0 additions & 10 deletions pkg/cli/workflows/test-claude-command.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 0 additions & 10 deletions pkg/cli/workflows/test-claude-create-issue.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 0 additions & 10 deletions pkg/cli/workflows/test-claude-create-pull-request.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 0 additions & 10 deletions pkg/cli/workflows/test-claude-mcp.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 0 additions & 10 deletions pkg/cli/workflows/test-claude-missing-tool.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 0 additions & 10 deletions pkg/cli/workflows/test-claude-push-to-pr-branch.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 0 additions & 10 deletions pkg/cli/workflows/test-claude-update-issue.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 0 additions & 10 deletions pkg/cli/workflows/test-playwright-accessibility-contrast.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

30 changes: 8 additions & 22 deletions pkg/workflow/agentic_output_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -90,13 +90,13 @@ This workflow tests the agentic output collection functionality.
t.Error("Expected output instructions to be injected into prompt")
}

// Verify Claude engine declared outputs are uploaded separately
if !strings.Contains(lockContent, "- name: Upload engine output files") {
t.Error("Expected 'Upload engine output files' step for Claude engine")
// Verify Claude engine no longer has upload steps (Claude CLI no longer produces output.txt)
if strings.Contains(lockContent, "- name: Upload engine output files") {
t.Error("Claude workflow should NOT have 'Upload engine output files' step (Claude CLI no longer produces output.txt)")
}

if !strings.Contains(lockContent, "name: agent_outputs") {
t.Error("Expected engine output artifact to be named 'agent_outputs'")
if strings.Contains(lockContent, "name: agent_outputs") {
t.Error("Claude workflow should NOT reference 'agent_outputs' artifact (Claude CLI no longer produces output.txt)")
}

// Verify Print Agent output step has file existence check
Expand Down Expand Up @@ -218,16 +218,12 @@ This workflow tests that Codex engine gets GITHUB_AW_SAFE_OUTPUTS but not engine
}

func TestEngineOutputFileDeclarations(t *testing.T) {
// Test Claude engine declares output files
// Test Claude engine declares no output files (Claude CLI no longer produces output.txt)
claudeEngine := NewClaudeEngine()
claudeOutputFiles := claudeEngine.GetDeclaredOutputFiles()

if len(claudeOutputFiles) == 0 {
t.Error("Claude engine should declare at least one output file")
}

if !stringSliceContains(claudeOutputFiles, "output.txt") {
t.Errorf("Claude engine should declare 'output.txt' as an output file, got: %v", claudeOutputFiles)
if len(claudeOutputFiles) != 0 {
t.Errorf("Claude engine should declare no output files (Claude CLI no longer produces output.txt), got: %v", claudeOutputFiles)
}

// Test Codex engine declares no output files
Expand All @@ -241,13 +237,3 @@ func TestEngineOutputFileDeclarations(t *testing.T) {
t.Logf("Claude engine declares: %v", claudeOutputFiles)
t.Logf("Codex engine declares: %v", codexOutputFiles)
}

// Helper function to check if a string slice contains a specific string
func stringSliceContains(slice []string, item string) bool {
for _, s := range slice {
if s == item {
return true
}
}
return false
}
2 changes: 1 addition & 1 deletion pkg/workflow/claude_engine.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ func (e *ClaudeEngine) GetInstallationSteps(workflowData *WorkflowData) []GitHub

// GetDeclaredOutputFiles returns the output files that Claude may produce
func (e *ClaudeEngine) GetDeclaredOutputFiles() []string {
return []string{"output.txt"}
return []string{}
}

// GetExecutionSteps returns the GitHub Actions steps for executing Claude
Expand Down
Loading