Fix upload-asset job: Add ScriptFile support for external script loading#8465
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Investigate and fix upload-asset job
Fix upload-asset job: Add ScriptFile support for external script loading
Jan 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
upload_assetsjob was compiling with an emptyscript: |block becausegetUploadAssetsScript()returns an empty string after embedded scripts were removed in favor of external actions loaded viarequire().Changes
pkg/workflow/publish_assets.go
ScriptName: "upload_assets"toSafeOutputJobConfigpkg/workflow/safe_outputs_steps.go
buildGitHubScriptStep()to supportScriptFileparameter (previously onlybuildGitHubScriptStepWithoutDownload()had this)ScriptFilefallback inbuildCustomActionStep()when action registry lookup failspkg/workflow/safe_outputs_jobs.go
ScriptFilefromScriptNamein inline mode:scriptName → scriptName.cjsResult
Workflows now generate proper require() statements instead of empty script blocks:
Affects 23 workflows using
upload-assetsafe output.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.