Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pkg/campaign/orchestrator_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,10 @@ func TestBuildOrchestrator_BasicShape(t *testing.T) {

func TestBuildOrchestrator_NoTrackerLabelDoesNotMentionTracker(t *testing.T) {
spec := &CampaignSpec{
ID: "test-campaign",
Name: "Test Campaign",
ProjectURL: "https://github.com/orgs/test/projects/1",
Workflows: []string{"test-workflow"},
ID: "test-campaign",
Name: "Test Campaign",
ProjectURL: "https://github.com/orgs/test/projects/1",
Workflows: []string{"test-workflow"},
TrackerLabel: "",
}

Expand Down
4 changes: 2 additions & 2 deletions pkg/campaign/template_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,8 @@ func TestRenderProjectUpdateInstructions(t *testing.T) {
{
name: "with project URL and campaign ID",
data: CampaignPromptData{
ProjectURL: "https://github.com/orgs/test/projects/1",
CampaignID: "my-campaign",
ProjectURL: "https://github.com/orgs/test/projects/1",
CampaignID: "my-campaign",
},
shouldContain: []string{
"Project Board Integration",
Expand Down
1 change: 0 additions & 1 deletion pkg/cli/compile_integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ package cli

import (
"bytes"
"context"
"io"
"os"
"os/exec"
Expand Down
6 changes: 3 additions & 3 deletions pkg/cli/interfaces_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,21 +27,21 @@ func TestCommandProviderInterface(t *testing.T) {
t.Run("GenBashCompletion", func(t *testing.T) {
var buf bytes.Buffer
err := provider.GenBashCompletion(&buf)
assert.NoError(t, err, "GenBashCompletion should not error")
require.NoError(t, err, "GenBashCompletion should not error")
assert.NotEmpty(t, buf.String(), "GenBashCompletion should generate content")
})

t.Run("GenZshCompletion", func(t *testing.T) {
var buf bytes.Buffer
err := provider.GenZshCompletion(&buf)
assert.NoError(t, err, "GenZshCompletion should not error")
require.NoError(t, err, "GenZshCompletion should not error")
assert.NotEmpty(t, buf.String(), "GenZshCompletion should generate content")
})

t.Run("GenFishCompletion", func(t *testing.T) {
var buf bytes.Buffer
err := provider.GenFishCompletion(&buf, true)
assert.NoError(t, err, "GenFishCompletion should not error")
require.NoError(t, err, "GenFishCompletion should not error")
assert.NotEmpty(t, buf.String(), "GenFishCompletion should generate content")
})
}
Expand Down
1 change: 0 additions & 1 deletion pkg/cli/run_command_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
package cli

import (
"context"
"fmt"
"strings"
"testing"
Expand Down
1 change: 0 additions & 1 deletion pkg/cli/status_command.go
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,6 @@ func getMarkdownWorkflowFiles() ([]string, error) {
return getMarkdownWorkflowFilesInDir(getWorkflowsDir())
}


// getMarkdownWorkflowFilesInDir finds all markdown workflow files in the provided directory.
// This is primarily used for shell completions and tests to avoid relying on process-wide cwd.
func getMarkdownWorkflowFilesInDir(workflowsDir string) ([]string, error) {
Expand Down
2 changes: 1 addition & 1 deletion pkg/workflow/safe_output_validation_config.go
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ var ValidationConfig = map[string]TypeValidationConfig{
},
},
"update_project": {
DefaultMax: 10,
DefaultMax: 10,
CustomValidation: "updateProjectValidTarget",
Fields: map[string]FieldValidation{
"project": {Required: true, Type: "string", Sanitize: true, MaxLength: 512, Pattern: "^https://github\\.com/(orgs|users)/[^/]+/projects/\\d+", PatternError: "must be a full GitHub project URL (e.g., https://github.com/orgs/myorg/projects/42)"},
Expand Down