fix: update test expectations for handler manager and context parameters#8675
Merged
mnkiefer merged 4 commits intoupdate-campaign-logicfrom Jan 2, 2026
Merged
fix: update test expectations for handler manager and context parameters#8675mnkiefer merged 4 commits intoupdate-campaign-logicfrom
mnkiefer merged 4 commits intoupdate-campaign-logicfrom
Conversation
- Fixed TestConsolidatedSafeOutputsJobIntegration to reflect handler manager consolidation - Added context.Context parameter to RunWorkflowOnGitHub and RunWorkflowsOnGitHub calls in tests - Updated expected step names to match actual behavior (process_safe_outputs instead of individual steps) Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
- Changed audit tool parameter from "run_id" to "run_id_or_url" in tests - Fixed TestMCPServer_ErrorCodes_InternalError test - Fixed TestMCPServer_AllToolsReturnContent test - Improved test parameter correctness Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Chore: Enhance campaign management features
fix: update test expectations for handler manager and context parameters
Jan 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test suite failures after safe output handler manager consolidation and context cancellation support.
Changes
Safe output test expectations (
safe_outputs_integration_test.go)TestConsolidatedSafeOutputsJobIntegrationto expectprocess_safe_outputsstep instead of individualcreate_issue/add_commentstepsContext parameter signatures (
run_command_test.go)context.Contextas first parameter to allRunWorkflowOnGitHubandRunWorkflowsOnGitHubtest callsMCP server test parameters (
mcp_server_*_test.go)run_idtorun_id_or_urlin test fixturesTest Status
--cmdflag remain failing (pre-existing from commit 4b211c5)💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.