Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions workflow
Fix TypeScript compilation errors in mark_pull_request_as_ready_for_review.cjs
Jan 2, 2026
pelikhan
approved these changes
Jan 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
mark_pull_request_as_ready_for_review.cjsfile was callinggenerateFooter()with only 2 arguments after the function signature was updated to require 7 parameters. This caused TypeScript compilation to fail in the "js" workflow.Changes
Updated
generateFooter()call to include all 7 required parameters:workflowSourceandworkflowSourceURLfrom environment variablestriggeringIssueNumber,triggeringPRNumber, andtriggeringDiscussionNumberextracted from context payloadFixed error handling to properly type the error variable using
error instanceof Errorcheck before accessingerror.messageFixed testifylint warnings in
interfaces_test.goby usingrequire.NoError()instead ofassert.NoError()for error assertionsExample
This aligns the footer generation with other safe output handlers like
create_issue.cjsandcreate_pr_review_comment.cjs.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/user/usr/bin/gh gh api user --jq .login -json GO111MODULE ux-amd64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE pleH4qtNyH2o env -json GO111MODULE 84e8ad814d76b70f05b571bccb740b3a-d/gh-aw GOINSECURE GOMOD GOMODCACHE 84e8ad814d76b70f-trimpath(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.