Skip to content

Fix TypeScript compilation errors in mark_pull_request_as_ready_for_review.cjs#8678

Merged
pelikhan merged 3 commits intomainfrom
copilot/fix-github-actions-workflow-again
Jan 2, 2026
Merged

Fix TypeScript compilation errors in mark_pull_request_as_ready_for_review.cjs#8678
pelikhan merged 3 commits intomainfrom
copilot/fix-github-actions-workflow-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jan 2, 2026

The mark_pull_request_as_ready_for_review.cjs file was calling generateFooter() with only 2 arguments after the function signature was updated to require 7 parameters. This caused TypeScript compilation to fail in the "js" workflow.

Changes

  • Updated generateFooter() call to include all 7 required parameters:

    • Added workflowSource and workflowSourceURL from environment variables
    • Added triggeringIssueNumber, triggeringPRNumber, and triggeringDiscussionNumber extracted from context payload
  • Fixed error handling to properly type the error variable using error instanceof Error check before accessing error.message

  • Fixed testifylint warnings in interfaces_test.go by using require.NoError() instead of assert.NoError() for error assertions

Example

// Before
const footer = generateFooter(workflowName, runUrl);

// After  
const footer = generateFooter(
  workflowName, 
  runUrl, 
  workflowSource, 
  workflowSourceURL, 
  triggeringIssueNumber, 
  triggeringPRNumber, 
  triggeringDiscussionNumber
);

This aligns the footer generation with other safe output handlers like create_issue.cjs and create_pr_review_comment.cjs.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/user
    • Triggering command: /usr/bin/gh gh api user --jq .login -json GO111MODULE ux-amd64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE pleH4qtNyH2o env -json GO111MODULE 84e8ad814d76b70f05b571bccb740b3a-d/gh-aw GOINSECURE GOMOD GOMODCACHE 84e8ad814d76b70f-trimpath (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

Fix the failing GitHub Actions workflow js

Analyze the workflow logs, identify the root cause of the failure, and implement a fix.

Job ID: 59339022879

Job URL: https://github.com/githubnext/gh-aw/actions/runs/20666249127/job/59339022879


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits January 2, 2026 20:52
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions workflow Fix TypeScript compilation errors in mark_pull_request_as_ready_for_review.cjs Jan 2, 2026
Copilot AI requested a review from pelikhan January 2, 2026 21:02
@pelikhan pelikhan marked this pull request as ready for review January 2, 2026 21:02
@pelikhan pelikhan merged commit 610f899 into main Jan 2, 2026
4 checks passed
@pelikhan pelikhan deleted the copilot/fix-github-actions-workflow-again branch January 2, 2026 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants