Skip to content

Fix testifylint violations in gateway_test.go#8681

Merged
pelikhan merged 2 commits intomainfrom
copilot/fix-lint-go-workflow
Jan 2, 2026
Merged

Fix testifylint violations in gateway_test.go#8681
pelikhan merged 2 commits intomainfrom
copilot/fix-lint-go-workflow

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jan 2, 2026

The lint-go workflow was failing due to testifylint violations where comparison assertions used assert.True instead of the more semantic assert.Less.

Changes

  • Replace assert.True(t, a < b, msg) with assert.Less(t, a, b, msg) in TestGenerateMCPGatewayStartStep_WithEnvVars
// Before
assert.True(t, ghAwPos < githubMcpPos, "GH_AW_SAFE_OUTPUTS should come before GITHUB_MCP_SERVER_TOKEN")

// After
assert.Less(t, ghAwPos, githubMcpPos, "GH_AW_SAFE_OUTPUTS should come before GITHUB_MCP_SERVER_TOKEN")

This follows testifylint best practices for clearer assertion intent and better failure messages.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/user
    • Triggering command: /usr/bin/gh gh api user --jq .login ath ../../../.pr**/*.json GO111MODULE 0.1-go1.25.0.lin../../../.prettierignore GOINSECURE GOMOD GOMODCACHE go env tions-lock.json -errorsas GO111MODULE ux-amd64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE ux-amd64/pkg/tool/linux_amd64/compile (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

Fix the failing GitHub Actions workflow lint-go

Analyze the workflow logs, identify the root cause of the failure, and implement a fix.

Job ID: 59341345125

Job URL: https://github.com/githubnext/gh-aw/actions/runs/20667052100/job/59341345125


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Replace assert.True with assert.Less for comparison operations to comply with testifylint rules

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions workflow lint-go Fix testifylint violations in gateway_test.go Jan 2, 2026
Copilot AI requested a review from pelikhan January 2, 2026 21:44
@pelikhan pelikhan marked this pull request as ready for review January 2, 2026 21:44
@pelikhan pelikhan merged commit 8b4d865 into main Jan 2, 2026
4 checks passed
@pelikhan pelikhan deleted the copilot/fix-lint-go-workflow branch January 2, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants