Fix testifylint violations in gateway_test.go#8681
Merged
Conversation
Replace assert.True with assert.Less for comparison operations to comply with testifylint rules Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions workflow lint-go
Fix testifylint violations in gateway_test.go
Jan 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lint-go workflow was failing due to testifylint violations where comparison assertions used
assert.Trueinstead of the more semanticassert.Less.Changes
assert.True(t, a < b, msg)withassert.Less(t, a, b, msg)inTestGenerateMCPGatewayStartStep_WithEnvVarsThis follows testifylint best practices for clearer assertion intent and better failure messages.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/user/usr/bin/gh gh api user --jq .login ath ../../../.pr**/*.json GO111MODULE 0.1-go1.25.0.lin../../../.prettierignore GOINSECURE GOMOD GOMODCACHE go env tions-lock.json -errorsas GO111MODULE ux-amd64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE ux-amd64/pkg/tool/linux_amd64/compile(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.