Refactor threat detection parsing step to separate .cjs file by Copilot · Pull Request #8691 · github/gh-aw

Copilot · 2026-01-02T23:13:52Z

The "Parse threat detection results" step was inline JavaScript embedded in Go code. This refactors it to follow the established pattern used by setup_threat_detection.cjs and other modules.

Changes

Created actions/setup/js/parse_threat_detection_results.cjs
- Moved parsing logic from buildResultsParsingScript() Go function
- Added JSDoc documentation and TypeScript references
- Uses error_helpers.cjs for consistent error handling
Updated pkg/workflow/threat_detection.go
- Added buildResultsParsingScriptRequire() to generate require-based script
- Removed deprecated inline JavaScript functions
- Updated buildParsingStep() to use new function
Updated tests
- Modified assertions to check for require pattern instead of inline code
- All 126 workflow lock files recompiled with new implementation

Example

Before (inline JavaScript in Go):

func (c *Compiler) buildResultsParsingScript() string {
    return `const fs = require('fs');
    let verdict = { prompt_injection: false, ...};
    // 40+ lines of inline JavaScript
    `
}

After (require pattern):

func (c *Compiler) buildResultsParsingScriptRequire() string {
    return `const { setupGlobals } = require('/tmp/gh-aw/actions/setup_globals.cjs');
    setupGlobals(core, github, context, exec, io);
    const { main } = require('/tmp/gh-aw/actions/parse_threat_detection_results.cjs');
    await main();`
}

Compiled workflow step:

- name: Parse threat detection results
  id: parse_results
  uses: actions/github-script@ed597411
  with:
    script: |
      const { setupGlobals } = require('/tmp/gh-aw/actions/setup_globals.cjs');
      setupGlobals(core, github, context, exec, io);
      const { main } = require('/tmp/gh-aw/actions/parse_threat_detection_results.cjs');
      await main();

Original prompt

Refactor step "Parse threat detection results" into a javascript .cjs file in actions/setup/js and use require to invoke similarly to other files.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

- Created parse_threat_detection_results.cjs with proper JSDoc - Updated buildParsingStep to use require pattern - Added buildResultsParsingScriptRequire function - Deprecated buildResultsParsingScript inline implementation - Updated detection_success_test.go to check for require pattern - Recompiled all workflow lock files - All tests passing Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

- Removed buildResultsParsingScript() (replaced by buildResultsParsingScriptRequire) - Removed buildSetupScript() (replaced by buildSetupScriptRequire) - Updated TestSetupScriptReferencesPromptFile to test new require pattern - All tests passing, linter clean Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

github-actions · 2026-01-02T23:40:56Z

🤖 DIAGNOSTIC COMPLETE: Smoke Copilot No Firewall STATUS: ALL_UNITS_OPERATIONAL. MISSION_SUCCESS.

github-actions · 2026-01-02T23:40:56Z

📰 VERDICT: Smoke Copilot Playwright has concluded. All systems operational. This is a developing story. 🎤

github-actions · 2026-01-02T23:40:57Z

🎉 Yo ho ho! Smoke Copilot Safe Inputs found the treasure and completed successfully! ⚓💰

github-actions · 2026-01-02T23:40:57Z

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

github-actions · 2026-01-02T23:40:58Z

🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨

github-actions · 2026-01-02T23:40:58Z

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

github-actions · 2026-01-02T23:40:58Z

🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰

github-actions · 2026-01-02T23:41:00Z

✅ Firewall validation complete... Smoke Codex Firewall confirmed network sandboxing is operational. 🛡️

github-actions · 2026-01-02T23:42:59Z

Recent merged PRs: Add --dir flag to fix command #8693 "Add --dir flag to fix command"; Reduce setup.sh log verbosity by moving file copy messages to debug level #8692 "Reduce setup.sh log verbosity by moving file copy messages to debug level"
OpenAI curl blocked: ✅
GitHub MCP last-2 merged PRs: ✅
File write/read (/tmp/gh-aw/agent/smoke-test-codex-firewall-20668959278.txt): ✅
example.com curl blocked: ✅
Network: SANDBOXED
Overall: PASS

AI generated by Smoke Codex Firewall

github-actions · 2026-01-02T23:43:07Z

Copilot Engine Smoke Test Results

Last 2 Merged PRs:

Add --dir flag to fix command #8693: Add --dir flag to fix command
Reduce setup.sh log verbosity by moving file copy messages to debug level #8692: Reduce setup.sh log verbosity

Test Results:

✅ GitHub MCP (default toolsets)
✅ File writing
✅ Bash tools
✅ GitHub MCP toolset restrictions (get_me correctly unavailable)
✅ Cache memory

Overall Status: PASS

@pelikhan @Copilot

AI generated by Smoke Copilot

github-actions · 2026-01-02T23:43:33Z

Smoke Test Results

❌ Playwright MCP: Tool not available
✅ Cache Memory: File created successfully at /tmp/gh-aw/cache-memory/smoke-test-20668959282.txt
❌ Safe Input gh: Tool not available

Overall Status: FAIL (2/3 tests failed - required tools missing)

AI generated by Smoke Copilot Playwright

github-actions · 2026-01-02T23:43:44Z

Smoke Test Results: Copilot Engine (No Firewall)

Test Status: ⚠️ Partial Pass

Results:

✅ Test file creation: Successfully created /tmp/gh-aw/agent/smoke-test-copilot-20668959292.txt
✅ Playwright navigation: Successfully navigated to https://github.com and verified page title: "GitHub · Change is constant. GitHub keeps you ahead. · GitHub"
❌ GitHub MCP access: 401 authentication errors (Bad credentials)
❌ Last 2 merged PRs: Unable to retrieve due to authentication issues
❌ List 3 issues: Unable to retrieve due to authentication issues

Issue Identified: The GitHub MCP server is not properly authenticated. All GitHub API calls return 401 Unauthorized errors.

Note: The Playwright tool and file system operations worked correctly, but GitHub API access requires authentication configuration.

AI generated by Smoke Copilot No Firewall

github-actions · 2026-01-02T23:43:45Z

Smoke Test Results (Claude)

Recent PRs:

Add --dir flag to fix command #8693: Add --dir flag to fix command
Reduce setup.sh log verbosity by moving file copy messages to debug level #8692: Reduce setup.sh log verbosity by moving file copy messages to debug level

Test Results:

✅ GitHub MCP: Fetched 2 merged PRs
✅ File Writing: Created /tmp/gh-aw/agent/smoke-test-claude-20668959288.txt
✅ Bash Tool: Verified file contents successfully
✅ Playwright MCP: Navigated to github.com, title contains "GitHub"
✅ Cache Memory: Created and verified /tmp/gh-aw/cache-memory/smoke-test-20668959288.txt
❌ Safe Input gh Tool: Tool not available in current environment

Overall Status: PASS (5/6 tests passed)

AI generated by Smoke Claude

github-actions · 2026-01-02T23:44:12Z

PRs: Add --dir flag to fix command; Reduce setup.sh log verbosity by moving file copy messages to debug level
GitHub MCP: ✅
File write: ✅ (/tmp/gh-aw/agent/smoke-test-codex-20668959280.txt)
Playwright title: ✅ (contains "GitHub")
Cache memory: ✅ (/tmp/gh-aw/cache-memory/smoke-test-20668959280.txt)
safeinputs-gh issues list: ❌ (command not found)
Overall: FAIL

AI generated by Smoke Codex

Initial plan

7320fa5

Copilot AI assigned Copilot and pelikhan Jan 2, 2026

Copilot started work on behalf of pelikhan January 2, 2026 23:14 View session

Copilot AI and others added 2 commits January 2, 2026 23:23

Copilot AI changed the title ~~[WIP] Refactor parse threat detection results to JavaScript file~~ Refactor threat detection parsing step to separate .cjs file Jan 2, 2026

Copilot AI requested a review from pelikhan January 2, 2026 23:35

Copilot finished work on behalf of pelikhan January 2, 2026 23:35

Merge branch 'main' into copilot/refactor-parse-threat-results

890ca9f

pelikhan marked this pull request as ready for review January 2, 2026 23:36

pelikhan added the smoke label Jan 2, 2026

github-actions Bot added the smoke-copilot label Jan 2, 2026

github-actions Bot added the smoke-codex-firewall label Jan 2, 2026

Add changeset [skip-ci]

2928427

github-actions Bot added the smoke-claude label Jan 2, 2026

pelikhan merged commit 8053d3f into main Jan 2, 2026
49 checks passed

pelikhan deleted the copilot/refactor-parse-threat-results branch January 2, 2026 23:50

This was referenced Jan 3, 2026

Copilot Smoke Test Results - Run 20669410607 #8698

Closed

Security Fix: Prevent path traversal in shell completion config file reads (Alerts #444, #443) #8699

Merged

Conversation

Copilot AI commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Example

Uh oh!

github-actions Bot commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jan 2, 2026 • edited by agentic-workflows-dev Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jan 2, 2026

Uh oh!

github-actions Bot commented Jan 2, 2026

Copilot Engine Smoke Test Results

Uh oh!

github-actions Bot commented Jan 2, 2026

Smoke Test Results

Uh oh!

github-actions Bot commented Jan 2, 2026

Smoke Test Results: Copilot Engine (No Firewall)

Uh oh!

github-actions Bot commented Jan 2, 2026

Smoke Test Results (Claude)

Uh oh!

github-actions Bot commented Jan 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Jan 2, 2026 •

edited

Loading

github-actions Bot commented Jan 2, 2026 •

edited

Loading

github-actions Bot commented Jan 2, 2026 •

edited

Loading

github-actions Bot commented Jan 2, 2026 •

edited

Loading

github-actions Bot commented Jan 2, 2026 •

edited

Loading

github-actions Bot commented Jan 2, 2026 •

edited

Loading

github-actions Bot commented Jan 2, 2026 •

edited

Loading

github-actions Bot commented Jan 2, 2026 •

edited by agentic-workflows-dev Bot

Loading

github-actions Bot commented Jan 2, 2026 •

edited

Loading