Skip to content

Import BBS archive with migrate-repo command#582

Merged
dylan-smith merged 34 commits intomainfrom
start-bbs-migrations
Aug 20, 2022
Merged

Import BBS archive with migrate-repo command#582
dylan-smith merged 34 commits intomainfrom
start-bbs-migrations

Conversation

@synthead
Copy link
Copy Markdown
Collaborator

@synthead synthead commented Aug 17, 2022

Closes #528!

This PR updates the placeholder migrate-repo command for bbs2gh with real logic to ingest an archive URL and kick off a migration with Octoshift.

A few notes about this PR:

  • There are some parameters that pass strings like "not-used" to satisfy required parameters in GraphQL and Octoshift. When https://github.com/github/octoshift/issues/5350 is shipped, these "filler" strings can be removed.
  • CreateBbsMigrationSource was added to GithubApi. This is consumed by the bbs2gh MigrateRepoCommand to kick off migrations over GraphQL.
  • bbs2gh.csproj was added as a reference to OctoshiftCLI.Tests.csproj. This is necessary to test classes in the OctoshiftCLI.BbsToGithub.Commands namespace.
  • I opted to use a MigrateRepoCommandArgs class in bbs2gh's MigrateRepoCommand because I felt that it was cleaner and easier to read.
  • Some unused ADO logic was pulled from bbs2gh's EnvironmentVariableProvider.
  • As for test coverage, I opted to find parity in the coverage for the GEI tests that is relevant to bbs2gh. I'm happy to add more coverage if desired 👍

Tasks

  • Did you write/update appropriate tests
  • Release notes updated (if appropriate)
  • Appropriate logging output
  • Issue linked
  • Docs updated (or issue created) (added bullet point to Document bbs2gh migrations #586)

@synthead synthead self-assigned this Aug 17, 2022
@synthead synthead added the bbs label Aug 17, 2022
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 17, 2022

Integration Test Results

4 tests   4 ✔️  12m 15s ⏱️
1 suites  0 💤
1 files    0

Results for commit 553391c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 17, 2022

Unit Test Results

481 tests   481 ✔️  25s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit 553391c.

♻️ This comment has been updated with latest results.

@synthead synthead marked this pull request as ready for review August 19, 2022 10:16
@dylan-smith
Copy link
Copy Markdown
Contributor

#586 is the tracking issue for docs, that will come later when we're getting ready for private beta.

@synthead synthead mentioned this pull request Aug 19, 2022
1 task
@synthead synthead requested a review from dylan-smith August 19, 2022 19:55
@github-actions
Copy link
Copy Markdown

Code Coverage

Package Line Rate Branch Rate Complexity Health
gei 86% 86% 343
ado2gh 88% 84% 498
bbs2gh 44% 24% 51
Octoshift 92% 78% 674
Summary 87% (4373 / 5000) 80% (933 / 1162) 1566

@dylan-smith dylan-smith merged commit 983803d into main Aug 20, 2022
@dylan-smith dylan-smith deleted the start-bbs-migrations branch August 20, 2022 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Call octoshift backend to ingest archive

2 participants