Import BBS archive with migrate-repo command#582
Merged
dylan-smith merged 34 commits intomainfrom Aug 20, 2022
Merged
Conversation
dylan-smith
reviewed
Aug 19, 2022
dylan-smith
reviewed
Aug 19, 2022
dylan-smith
reviewed
Aug 19, 2022
dylan-smith
reviewed
Aug 19, 2022
dylan-smith
reviewed
Aug 19, 2022
dylan-smith
reviewed
Aug 19, 2022
Contributor
|
#586 is the tracking issue for docs, that will come later when we're getting ready for private beta. |
dylan-smith
approved these changes
Aug 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #528!
This PR updates the placeholder
migrate-repocommand forbbs2ghwith real logic to ingest an archive URL and kick off a migration with Octoshift.A few notes about this PR:
"not-used"to satisfy required parameters in GraphQL and Octoshift. When https://github.com/github/octoshift/issues/5350 is shipped, these "filler" strings can be removed.CreateBbsMigrationSourcewas added toGithubApi. This is consumed by the bbs2ghMigrateRepoCommandto kick off migrations over GraphQL.bbs2gh.csprojwas added as a reference toOctoshiftCLI.Tests.csproj. This is necessary to test classes in theOctoshiftCLI.BbsToGithub.Commandsnamespace.MigrateRepoCommandArgsclass in bbs2gh'sMigrateRepoCommandbecause I felt that it was cleaner and easier to read.EnvironmentVariableProvider.Tasks
bbs2ghmigrations #586)