Conversation
dylan-smith
reviewed
Aug 20, 2022
dylan-smith
approved these changes
Aug 20, 2022
Contributor
dylan-smith
left a comment
dylan-smith
left a comment
There was a problem hiding this comment.
I left one comment about a minor potential improvement, but looks good!
ArinGhazarian
approved these changes
Aug 22, 2022
Contributor
ArinGhazarian
left a comment
ArinGhazarian
left a comment
There was a problem hiding this comment.
Looks good 👍 , just added a nit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first step in migrating BBS repos is to tell the source instance to generate the archive, then to query the REST API to get the state of the export (until it's done). Additionally, we want to be able to query the server to get its version, to make sure it's one that supports the export API. This PR adds a minimal, naïve implementation of
BbsClient(which abstracts away talking to the BBS source instance) andBbsApi, which formalizes the API endpoints we want to hit as we kick off a migration.Closes #524
Release notes updated (if appropriate)Docs updated (or issue created)