Retry non-200 GET requests from AdoClient, BbsClient and GithubClient#620
Merged
Retry non-200 GET requests from AdoClient, BbsClient and GithubClient#620
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
co-authored-by: Dylan Smith <dylan-smith@github.com>
co-authored-by: Dylan Smith <dylan-smith@github.com>
co-authored-by: Dylan Smith <dylan-smith@github.com>
synthead
changed the title
ArinGhazarian
suggested changes
Sep 9, 2022
Contributor
ArinGhazarian
left a comment
ArinGhazarian
left a comment
There was a problem hiding this comment.
Very solid PR, I just added a few suggestion.
|
dylan-smith
approved these changes
Sep 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #587! ✨
This PR ensures that all non-200 GET requests from
AdoClient,BbsClientandGithubClientgets retried viaRetryPolicy.HttpRetry. This will allow us to retry on transient network issues for more robust and consistent migrations.Docs updated (or issue created)(n/a)