Prevent race condition on cutover completion#1664
Merged
Conversation
jakubpliszka
requested review from
meiji163,
rashiq and
timvaillancourt
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a race where the heartbeat goroutine may continue writing to the changelog table while cleanup is dropping it, leading to a post-success panic.
Changes:
- Stop heartbeat injection when
migrationContext.CutOverCompleteFlagindicates cutover has completed.
Show a summary per file
| File | Description |
|---|---|
| go/logic/applier.go | Adds a guard in the heartbeat loop to exit once cutover is marked complete. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
Comment on lines
749
to
+755
| if atomic.LoadInt64(&this.finishedMigrating) > 0 { | ||
| return | ||
| } | ||
|
|
||
| if atomic.LoadInt64(&this.migrationContext.CutOverCompleteFlag) > 0 { | ||
| return | ||
| } |
meiji163
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a race between the heartbeat goroutine and
finalCleanup()that can cause gh-ost to panic with a misleading FATAL after a successful migration:script/cibuildreturns with no formatting errors, build errors or unit test errors.