testing/running on replica: gets lags via SHOW SLAVE STATUS#365
Merged
shlomi-noach merged 2 commits intomasterfrom Feb 7, 2017
Merged
testing/running on replica: gets lags via SHOW SLAVE STATUS#365shlomi-noach merged 2 commits intomasterfrom
shlomi-noach merged 2 commits intomasterfrom
Conversation
Contributor
Author
|
Note that it is still possible to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup on #347
on
test-on-replicaormigrate-on-replica, relying on the internal changelog heartbeat is incorrect behavior and leads to lags. This is because is those cases the heartbeat is injected onto the replica in the first place. So clearly as we read it it will be happy and up-to-date. But this means we're overloading the replica with our migration, causing it to lag.With this PR, on
test-on-replicaormigrate-on-replica, we readSHOW SLAVE STATUSof the replica. This will have 1-second granularity but this is fine for running on replica.